components/autofill/core/browser/webdata/autofill_table.cc - Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_table.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/server_field_types_util.cc ('k') | components/autofill/core/browser/webdata/autofill_table_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_table.cc

diff --git a/components/autofill/core/browser/webdata/autofill_table.cc b/components/autofill/core/browser/webdata/autofill_table.cc

index 07a291c1a21be74a0150c2bd1b21f76d9c3c7e1e..2b40540e1c746fa2575e0d9655ef654772e742ea 100644

--- a/components/autofill/core/browser/webdata/autofill_table.cc

+++ b/components/autofill/core/browser/webdata/autofill_table.cc

@@ -140,7 +140,7 @@ void BindCreditCardToStatement(const CreditCard& credit_card,

int index = 0;

s->BindString(index++, credit_card.guid());

- s->BindString16(index++, GetInfo(credit_card, CREDIT_CARD_NAME));

+ s->BindString16(index++, GetInfo(credit_card, CREDIT_CARD_NAME_FULL));

s->BindString16(index++, GetInfo(credit_card, CREDIT_CARD_EXP_MONTH));

s->BindString16(index++, GetInfo(credit_card, CREDIT_CARD_EXP_4_DIGIT_YEAR));

BindEncryptedCardToColumn(s, index++,

@@ -173,7 +173,7 @@ scoped_ptr<CreditCard> CreditCardFromStatement(const sql::Statement& s) {

credit_card->set_guid(s.ColumnString(index++));

DCHECK(base::IsValidGUID(credit_card->guid()));

- credit_card->SetRawInfo(CREDIT_CARD_NAME, s.ColumnString16(index++));

+ credit_card->SetRawInfo(CREDIT_CARD_NAME_FULL, s.ColumnString16(index++));

credit_card->SetRawInfo(CREDIT_CARD_EXP_MONTH, s.ColumnString16(index++));

credit_card->SetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR,

s.ColumnString16(index++));

@@ -1228,7 +1228,7 @@ bool AutofillTable::GetServerCreditCards(

}

card->SetServerStatus(ServerStatusStringToEnum(s.ColumnString(index++)));

- card->SetRawInfo(CREDIT_CARD_NAME, s.ColumnString16(index++));

+ card->SetRawInfo(CREDIT_CARD_NAME_FULL, s.ColumnString16(index++));

card->SetRawInfo(CREDIT_CARD_EXP_MONTH, s.ColumnString16(index++));

card->SetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR, s.ColumnString16(index++));

credit_cards->push_back(card);

@@ -1265,7 +1265,7 @@ void AutofillTable::SetServerCreditCards(

masked_insert.BindString(1, card.type());

masked_insert.BindString(2,

ServerStatusEnumToString(card.GetServerStatus()));

- masked_insert.BindString16(3, card.GetRawInfo(CREDIT_CARD_NAME));

+ masked_insert.BindString16(3, card.GetRawInfo(CREDIT_CARD_NAME_FULL));

masked_insert.BindString16(4, card.LastFourDigits());

masked_insert.BindString16(5, card.GetRawInfo(CREDIT_CARD_EXP_MONTH));

masked_insert.BindString16(6,