Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1694433003: DevTools: [CSS] Add CSS.setMultipleStyleTexts command to CSS domain (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [CSS] Add CSS.setMultipleStyleTexts command to CSS domain BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/3898d506818649c772175ea95bcdf9a7ee9bbadc Cr-Commit-Position: refs/heads/master@{#376336}

Patch Set 1 #

Patch Set 2 : rebaseline #

Total comments: 10

Patch Set 3 : address comments #

Total comments: 8

Patch Set 4 : address comments #

Total comments: 2

Patch Set 5 : address comments #

Patch Set 6 : %zu is not cross-platform - do not use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -91 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js View 1 2 3 4 2 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-inline-style-text.html View 1 2 4 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-inline-style-text-expected.txt View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-multiple-style-texts.html View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-multiple-style-texts-expected.txt View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-style-text.html View 1 2 5 chunks +24 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-style-text-expected.txt View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-new-API.html View 1 2 1 chunk +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 5 4 chunks +101 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHistory.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHistory.cpp View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js View 1 2 3 2 chunks +48 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 35 (14 generated)
lushnikov
ptal
4 years, 10 months ago (2016-02-12 02:30:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694433003/1
4 years, 10 months ago (2016-02-12 18:47:13 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/130433) ios_rel_device_ninja on ...
4 years, 10 months ago (2016-02-12 18:51:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694433003/20001
4 years, 10 months ago (2016-02-12 19:40:49 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/166271)
4 years, 10 months ago (2016-02-12 20:56:25 UTC) #9
dgozman
https://codereview.chromium.org/1694433003/diff/20001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1694433003/diff/20001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#newcode426 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:426: revert->undo(undoExceptionState); ASSERT undo was successful? Or propagate exception to ...
4 years, 10 months ago (2016-02-16 18:14:05 UTC) #10
lushnikov
ptal https://codereview.chromium.org/1694433003/diff/20001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1694433003/diff/20001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#newcode426 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:426: revert->undo(undoExceptionState); On 2016/02/16 18:14:05, dgozman wrote: > ASSERT ...
4 years, 10 months ago (2016-02-17 20:26:50 UTC) #11
dgozman
https://codereview.chromium.org/1694433003/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js File third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js (right): https://codereview.chromium.org/1694433003/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js#newcode17 third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js:17: options.styleSheetId = styleSheetId; This does not work for multiple ...
4 years, 10 months ago (2016-02-17 23:32:36 UTC) #12
lushnikov
https://codereview.chromium.org/1694433003/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js File third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js (right): https://codereview.chromium.org/1694433003/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js#newcode17 third_party/WebKit/LayoutTests/http/tests/inspector-protocol/css-protocol-test.js:17: options.styleSheetId = styleSheetId; On 2016/02/17 23:32:35, dgozman wrote: > ...
4 years, 10 months ago (2016-02-18 01:40:16 UTC) #13
lushnikov
https://codereview.chromium.org/1694433003/diff/40001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1694433003/diff/40001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#newcode379 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:379: int getMultipleStyleTextsActionId() On 2016/02/17 23:32:36, dgozman wrote: > static ...
4 years, 10 months ago (2016-02-18 01:40:57 UTC) #14
dgozman
lgtm https://codereview.chromium.org/1694433003/diff/60001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1694433003/diff/60001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#newcode1296 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1296: extra empty line
4 years, 10 months ago (2016-02-18 02:11:00 UTC) #15
lushnikov
https://codereview.chromium.org/1694433003/diff/60001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/1694433003/diff/60001/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp#newcode1296 third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1296: On 2016/02/18 02:11:00, dgozman wrote: > extra empty line ...
4 years, 10 months ago (2016-02-18 02:49:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694433003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694433003/80001
4 years, 10 months ago (2016-02-18 02:51:22 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/175485)
4 years, 10 months ago (2016-02-18 05:11:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694433003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694433003/80001
4 years, 10 months ago (2016-02-18 05:14:05 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/175546)
4 years, 10 months ago (2016-02-18 08:34:55 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694433003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694433003/80001
4 years, 10 months ago (2016-02-18 17:33:42 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/175793)
4 years, 10 months ago (2016-02-18 21:21:53 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694433003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694433003/100001
4 years, 10 months ago (2016-02-19 00:07:40 UTC) #32
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-19 01:38:04 UTC) #33
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 01:38:59 UTC) #35
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/3898d506818649c772175ea95bcdf9a7ee9bbadc
Cr-Commit-Position: refs/heads/master@{#376336}

Powered by Google App Engine
This is Rietveld 408576698