Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 169443007: Always use the app icon as the taskbar icon for windowed streamlined hosted apps. (Closed)

Created:
6 years, 10 months ago by calamity
Modified:
6 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Always use the app icon as the taskbar icon for windowed streamlined hosted apps. Hosted app windows currently use the current URL to determine the taskbar icon. This CL makes hosted app windows always use the app icon which provides a higher resolution icon than is currently provided and provides the window with a better sense of identity since the icon doesn't change. BUG=318607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251749

Patch Set 1 #

Patch Set 2 : maintain logic in the non-app-window case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
chrome/browser/extensions/tab_helper.cc View 1 4 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
calamity
6 years, 10 months ago (2014-02-18 03:21:52 UTC) #1
benwells
lgtm
6 years, 10 months ago (2014-02-18 05:56:58 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 10 months ago (2014-02-18 05:59:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/169443007/130001
6 years, 10 months ago (2014-02-18 05:59:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 07:20:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265466
6 years, 10 months ago (2014-02-18 07:20:40 UTC) #6
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 10 months ago (2014-02-18 10:01:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/169443007/130001
6 years, 10 months ago (2014-02-18 10:01:55 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 11:38:37 UTC) #9
Message was sent while issue was closed.
Change committed as 251749

Powered by Google App Engine
This is Rietveld 408576698