Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: mojo/dart/packages/mojo/sdk_ext/src/handle_watcher.dart

Issue 1694413003: Cleanups in the Mojo package. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo/sdk_ext/src/handle_watcher.dart
diff --git a/mojo/dart/packages/mojo/sdk_ext/src/handle_watcher.dart b/mojo/dart/packages/mojo/sdk_ext/src/handle_watcher.dart
index 3e6201a0f41058318bcb361061f821ab44dfb0e0..c2de1a6586e19c99c6f983093e9cce41dfb77f5f 100644
--- a/mojo/dart/packages/mojo/sdk_ext/src/handle_watcher.dart
+++ b/mojo/dart/packages/mojo/sdk_ext/src/handle_watcher.dart
@@ -34,8 +34,8 @@ class MojoHandleWatcher {
/// Stops watching and closes the given [handleToken].
///
- /// Returns an integer, encoding the result as specified in the [MojoResult]
- /// class. In particular, a successful operation returns [MojoResult.kOk].
+ /// Returns an integer, encoding the result as specified in [MojoConstants].
+ /// In particular, a successful operation returns [MojoConstants.kOk].
///
/// Notifies the HandleWatcherIsolate that a handle it is
/// watching should be removed from its set and closed.
@@ -63,8 +63,8 @@ class MojoHandleWatcher {
/// Starts watching for events on the given [handleToken].
///
- /// Returns an integer, encoding the result as specified in the [MojoResult]
- /// class. In particular, a successful operation returns [MojoResult.kOk].
+ /// Returns an integer, encoding the result as specified in [MojoConstants].
+ /// In particular, a successful operation returns [MojoConstants.kOk].
///
/// Instructs the MojoHandleWatcher isolate to add [handleToken] to the set of
/// handles it watches, and to notify the calling isolate only for the events
@@ -75,8 +75,9 @@ class MojoHandleWatcher {
/// The [handleToken] is a token that identifies the Mojo handle.
///
/// The filtering [signals] are encoded as specified in the
- /// [MojoHandleSignals] class. For example, setting [signals] to
- /// [MojoHandleSignals.kPeerClosedReadable] instructs the handle watcher to
+ /// [MojoConstants] class (section "Handle Signals"). For example, setting
+ /// [signals] to the bitwise union of [MojoConstants.kPeerClosed]
+ /// [MojoConstants.kReadable] instructs the handle watcher to
/// notify the caller, when the handle becomes readable (that is, has data
/// available for reading), or when it is closed.
static int add(int handleToken, SendPort port, int signals) {
@@ -85,8 +86,8 @@ class MojoHandleWatcher {
/// Stops watching the given [handleToken].
///
- /// Returns an integer, encoding the result as specified in the [MojoResult]
- /// class. In particular, a successful operation returns [MojoResult.kOk].
+ /// Returns an integer, encoding the result as specified in [MojoConstants].
+ /// In particular, a successful operation returns [MojoConstants.kOk].
///
/// Instructs the MojoHandleWatcher isolate to remove [handleToken] from the
/// set of handles it watches. This allows the application isolate
@@ -99,8 +100,8 @@ class MojoHandleWatcher {
/// Requests a notification on the given [port] at [deadline].
///
- /// Returns an integer, encoding the result as specified in the [MojoResult]
- /// class. In particular, a successful operation returns [MojoResult.kOk].
+ /// Returns an integer, encoding the result as specified in [MojoConstants].
+ /// In particular, a successful operation returns [MojoConstants.kOk].
///
/// The [deadline] is in milliseconds, with
/// [MojoCoreNatives.timerMillisecondClock] as reference.
« no previous file with comments | « mojo/dart/packages/mojo/sdk_ext/src/constants.dart ('k') | mojo/dart/packages/mojo/sdk_ext/src/natives.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698