Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: mojo/dart/packages/mojo/lib/src/message_pipe.dart

Issue 1694413003: Cleanups in the Mojo package. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/packages/mojo/lib/src/handle.dart ('k') | mojo/dart/packages/mojo/lib/src/types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/packages/mojo/lib/src/message_pipe.dart
diff --git a/mojo/dart/packages/mojo/lib/src/message_pipe.dart b/mojo/dart/packages/mojo/lib/src/message_pipe.dart
index 7ecf10137393fa855e4f5c67f27b63d9af7f9b37..b638c4943e9fc9a7cb0bc236b91947afc57208f2 100644
--- a/mojo/dart/packages/mojo/lib/src/message_pipe.dart
+++ b/mojo/dart/packages/mojo/lib/src/message_pipe.dart
@@ -54,9 +54,9 @@ class MojoMessagePipeQueryAndReadState {
}
class MojoMessagePipeEndpoint {
- static const int WRITE_FLAG_NONE = 0;
- static const int READ_FLAG_NONE = 0;
- static const int READ_FLAG_MAY_DISCARD = 1 << 0;
+ static const int WRITE_FLAG_NONE = MojoConstants.kNone;
+ static const int READ_FLAG_NONE = MojoConstants.kNone;
+ static const int READ_FLAG_MAY_DISCARD = MojoConstants.kMayDiscard;
static final _queryAndReadState = new MojoMessagePipeQueryAndReadState();
@@ -177,14 +177,14 @@ class MojoMessagePipeEndpoint {
}
class MojoMessagePipe {
- static const int FLAG_NONE = 0;
+ static const int flagNone = MojoConstants.kNone;
List<MojoMessagePipeEndpoint> endpoints;
int status;
MojoMessagePipe._() : status = MojoResult.kOk;
- factory MojoMessagePipe([int flags = FLAG_NONE]) {
+ factory MojoMessagePipe([int flags = flagNone]) {
List result = MojoMessagePipeNatives.MojoCreateMessagePipe(flags);
if (result == null) {
return null;
« no previous file with comments | « mojo/dart/packages/mojo/lib/src/handle.dart ('k') | mojo/dart/packages/mojo/lib/src/types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698