Cleanups in the Mojo package.

mojo/dart/packages/mojo/lib/src/buffer.dart

Index: mojo/dart/packages/mojo/lib/src/buffer.dart
diff --git a/mojo/dart/packages/mojo/lib/src/buffer.dart b/mojo/dart/packages/mojo/lib/src/buffer.dart
index 8c9e2ef09eb202040fa3e6be6663e60ec16bf9dd..cacc8c010251ad2d5d3d65ec1a0bba2650281a0c 100644
--- a/mojo/dart/packages/mojo/lib/src/buffer.dart
+++ b/mojo/dart/packages/mojo/lib/src/buffer.dart
@@ -5,9 +5,9 @@
 part of core;
 
 class MojoSharedBuffer {
-  static const int createFlagNone = 0;
-  static const int duplicateFlagNone = 0;
-  static const int mapFlagNone = 0;
+  static const int createFlagNone = MojoConstants.kNone;

[zra, 2016/02/16 16:58:26]

This indirection increases the amount of compilation we have to do at startup,
which will hurt startup time. What is the reason for the indirection?

[floitsch, 2016/02/16 17:03:54]

The constants are defined by the internal library and not the public package.
For example, the documentation of the internal library can't reference these
constants (even though it's the own defining what they actually mean).

Ideally the constants in MojoConstants should reference the ones in C, but that
seems to be too complicated.

+  static const int duplicateFlagNone = MojoConstants.kNone;
+  static const int mapFlagNone = MojoConstants.kNone;
 
   MojoHandle _handle;
   int _status = MojoResult.kOk;