Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1694403002: [runtime] Move heap-object type check helpers to HeapObject with wrapper on Object (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Move heap-object type check helpers to HeapObject with wrapper on Object BUG= Committed: https://crrev.com/099271a189bfd29d58c8ba129f41d510590f9c7d Cr-Commit-Position: refs/heads/master@{#34034}

Patch Set 1 #

Patch Set 2 : oddballs #

Patch Set 3 : #

Patch Set 4 : Don't cast undefined to jsfunction #

Patch Set 5 : #

Patch Set 6 : drop the dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -295 lines) Patch
M src/heap/heap.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact-inl.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 11 chunks +32 lines, -32 lines 0 comments Download
M src/objects-inl.h View 1 2 17 chunks +116 lines, -260 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-16 08:01:38 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-16 08:18:22 UTC) #4
Benedikt Meurer
LGTM.
4 years, 10 months ago (2016-02-16 08:21:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694403002/40001
4 years, 10 months ago (2016-02-16 08:22:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/1408) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-16 09:06:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694403002/40001
4 years, 10 months ago (2016-02-16 09:48:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/1416) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-16 10:25:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694403002/60001
4 years, 10 months ago (2016-02-16 11:02:30 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/10137)
4 years, 10 months ago (2016-02-16 11:29:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694403002/100001
4 years, 10 months ago (2016-02-16 12:22:50 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-16 12:57:49 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 12:57:54 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/099271a189bfd29d58c8ba129f41d510590f9c7d
Cr-Commit-Position: refs/heads/master@{#34034}

Powered by Google App Engine
This is Rietveld 408576698