Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 16944006: HCheckFunction is needed to protect new array constructors in (Closed)

Created:
7 years, 6 months ago by mvstanton
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

HCheckFunction is needed to protect new array constructors in crankshafted code. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -36 lines) Patch
M src/hydrogen.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/array-constructor-feedback.js View 3 chunks +49 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Danno, here is the CL we discussed, --Michael
7 years, 6 months ago (2013-06-13 14:08:34 UTC) #1
danno
lgtm
7 years, 6 months ago (2013-06-13 14:25:28 UTC) #2
mvstanton
7 years, 6 months ago (2013-06-13 14:29:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698