sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 16944004: Change how we deal with manual inlining of argument error and NSM when propagating types. This chan…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 16944004: Change how we deal with manual inlining of argument error and NSM when propagating types. This chan… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/bailout.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/bailout.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 23949)

+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)

@@ -2421,8 +2421,14 @@

js.Expression generateTest(HCheck node) {

HInstruction input = node.checkedInput;

+ TypeMask receiver = input.instructionType.computeMask(compiler);

+ TypeMask mask = node.instructionType.computeMask(compiler);

+ bool turnIntoNullCheck = mask.nullable() == receiver;

js.Expression test;

- if (node.isInteger()) {

+ if (turnIntoNullCheck) {

+ use(input);

+ test = new js.Binary("==", pop(), new js.LiteralNull());

+ } else if (node.isInteger()) {

// input is !int

checkInt(input, '!==');

test = pop();

@@ -2486,7 +2492,7 @@

new js.Binary('||', objectTest, notIndexingTest);

test = new js.Binary('&&', stringTest, notObjectOrIndexingTest);

} else {

- compiler.internalError('Unexpected type guard', instruction: input);

+ compiler.internalError('Unexpected check', instruction: input);

}

return test;

}