Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1694353004: MSAN: build libc++ with MSAN, link to it. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

MSAN: build libc++ with MSAN, link to it. The errors that we see should now change to the unexplainable, rather than the explainable errors at head. We suspect that the original reason to blacklist was this, not building libc++ with MSAN. So unblacklist everything to start fresh. BUG=skia:4903, skia:4900 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694353004 Committed: https://skia.googlesource.com/skia/+/0da8537555faf886a8cbac4bd0819ece9fa00dda

Patch Set 1 #

Patch Set 2 : missing #

Patch Set 3 : unblacklist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dm_flags.json View 1 2 1 chunk +1 line, -13 lines 0 comments Download
M tools/dm_flags.py View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M tools/xsan_build View 1 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
mtklein_C
4 years, 10 months ago (2016-02-16 20:00:39 UTC) #9
msarett
lgtm
4 years, 10 months ago (2016-02-16 20:13:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694353004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694353004/60001
4 years, 10 months ago (2016-02-16 21:39:46 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:03:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/0da8537555faf886a8cbac4bd0819ece9fa00dda

Powered by Google App Engine
This is Rietveld 408576698