Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1694343002: X87: [compiler] Sanitize entry points to LookupSlot access. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Sanitize entry points to LookupSlot access. port 4ff159bd28be36a39a1f8416cdf8fccafd3c2f95(r33880) original commit message: Add dedicated %LoadLookupSlot, %LoadLookupSlotInsideTypeof, %LoadLookupSlotForCall, %StoreLookupSlot_Sloppy and %StoreLookupSlot_Strict runtime entry points and use them appropriately in the various compilers. This way we can finally drop the machine operators from the JS graph level completely in TurboFan. Also drop the funky JSLoadDynamic operator from TurboFan, which was by now just a small wrapper around the runtime call to %LoadLookupSlot. BUG= Committed: https://crrev.com/b8162581bd004e200ae84c6df134d2126b80015f Cr-Commit-Position: refs/heads/master@{#34012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-16 03:16:55 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-16 04:30:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694343002/1
4 years, 10 months ago (2016-02-16 04:50:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 05:06:22 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 05:07:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8162581bd004e200ae84c6df134d2126b80015f
Cr-Commit-Position: refs/heads/master@{#34012}

Powered by Google App Engine
This is Rietveld 408576698