checkout.py - Issue 169433008: Instead of passing --author, lets just set the name/email for the repo temporarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: checkout.py

Issue 169433008: Instead of passing --author, lets just set the name/email for the repo temporarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: checkout.py

diff --git a/checkout.py b/checkout.py

index 2c9c68a7fd24ec5bcaa3df2cdd1ae89cd36bb59a..efdf3a5f1da92d2645034719216fa3e6fe21774c 100644

--- a/checkout.py

+++ b/checkout.py

@@ -713,11 +713,14 @@ class GitCheckout(CheckoutBase):

# index.

cmd = ['commit', '-m', 'Committed patch']

if name and email:

- author = '%s <%s>' % (name, email)

- cmd.extend(['--author', author])

+ self._check_call_git(['config', 'user.email', email])

agable 2014/02/22 01:18:09 Ewwwwwwww. Use git -c user.email=Foo user.name=Ba

Ryan Tseng 2014/02/22 01:47:16 Done.

+ self._check_call_git(['config', 'user.name', name])

if verbose:

cmd.append('--verbose')

self._check_call_git(cmd)

+ if name and email:

+ self._check_call_git(['config', '--unset', 'user.email', email])

+ self._check_call_git(['config', '--unset', 'user.name', name])

if self.base_ref:

base_ref = self.base_ref

else:

« no previous file with comments | « no previous file | no next file » | no next file with comments »