Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169433008: Instead of passing --author, lets just set the name/email for the repo temporarily. (Closed)

Created:
6 years, 10 months ago by Ryan Tseng
Modified:
6 years, 10 months ago
Reviewers:
agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Instead of passing --author, lets just set the name/email for the repo temporarily. BUG=339171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252729

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use -c, which is less hacky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M checkout.py View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Tseng
6 years, 10 months ago (2014-02-22 01:02:50 UTC) #1
agable
https://codereview.chromium.org/169433008/diff/1/checkout.py File checkout.py (right): https://codereview.chromium.org/169433008/diff/1/checkout.py#newcode716 checkout.py:716: self._check_call_git(['config', 'user.email', email]) Ewwwwwwww. Use git -c user.email=Foo user.name=Bar ...
6 years, 10 months ago (2014-02-22 01:18:08 UTC) #2
Ryan Tseng
https://codereview.chromium.org/169433008/diff/1/checkout.py File checkout.py (right): https://codereview.chromium.org/169433008/diff/1/checkout.py#newcode716 checkout.py:716: self._check_call_git(['config', 'user.email', email]) On 2014/02/22 01:18:09, agable wrote: > ...
6 years, 10 months ago (2014-02-22 01:47:15 UTC) #3
agable
lgtm
6 years, 10 months ago (2014-02-22 02:09:20 UTC) #4
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 10 months ago (2014-02-22 02:16:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/169433008/60001
6 years, 10 months ago (2014-02-22 02:16:47 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 02:20:15 UTC) #7
Message was sent while issue was closed. 
Change committed as 252729

Powered by Google App Engine
This is Rietveld 408576698