Issue 16943013: Fix file permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16943013: Fix file permissions (Closed)

Created:
7 years, 6 months ago by rmsousa

Modified:
7 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs			Patch
A	ui/base/ime/dummy_input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/dummy_input_method.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/fake_input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/fake_input_method.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_ibus.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_ibus.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_imm32.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_imm32.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_tsf.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_tsf.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/mock_input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/mock_input_method.cc	View	+-1 lines, --1 lines	0 comments	Download

Total messages: 4 (0 generated)

dmichael (off chromium)

Please reference the original CL and add that developer as TBR. o/w, lgtm. Thanks!

7 years, 6 months ago (2013-06-21 17:42:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmsousa@chromium.org/16943013/1

7 years, 6 months ago (2013-06-21 18:40:12 UTC) #3

rmsousa

7 years, 6 months ago (2013-06-21 20:12:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r207912 (presubmit successful).