Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 16943003: Rewrite scoped_ptr<T>(NULL) to use the default ctor. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, hclam+watch_chromium.org, sergeyu+watch_chromium.org, grt+watch_chromium.org, amit, sanjeevr, jam, garykac+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, lambroslambrou+watch_chromium.org, robertshield, weitaosu+watch_chromium.org, darin-cc_chromium.org, alexeypa+watch_chromium.org, wez+watch_chromium.org, rmsousa+watch_chromium.org
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor. This is a manual cleanup of call sites that invoke scoped_ptr<T>'s constructor with an explicit NULL argument, since the clang tooling infrastructure does not work on Windows. Also fixes a misuse of scoped_ptr<T> in chrome_frame to hold memory allocated by operator new[]. BUG=173286 R=alexeypa@chromium.org, erg@chromium.org, jochen@chromium.org, mmenke@chromium.org, tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/urlmon_bind_status_callback.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_drag_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_unified_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/setup/daemon_controller_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
tommi@ for chrome_frame/ and media/audio/ mmenke@ for chrome/browser/profiles/ and net/ jochen@ for content/browser/web_contents/ garykac@ for ...
7 years, 6 months ago (2013-06-17 03:28:05 UTC) #1
alexeypa (please no reviews)
remoting/ - lgtm
7 years, 6 months ago (2013-06-17 05:37:37 UTC) #2
jochen (gone - plz use gerrit)
content/browser/web_contents lgtm
7 years, 6 months ago (2013-06-17 07:28:57 UTC) #3
tommi (sloooow) - chröme
lgtm
7 years, 6 months ago (2013-06-17 11:59:48 UTC) #4
mmenke
On 2013/06/17 11:59:48, tommi wrote: > lgtm I'm only an owner of the profiles/ code ...
7 years, 6 months ago (2013-06-17 14:55:38 UTC) #5
dcheng
erg@, mind rubberstamping the changes in chrome/browser/profiles? Thanks!
7 years, 6 months ago (2013-06-17 14:57:55 UTC) #6
Elliot Glaysher
lgtm
7 years, 6 months ago (2013-06-17 17:09:55 UTC) #7
dcheng
7 years, 6 months ago (2013-06-17 18:46:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r206763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698