third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.html - Issue 1694263003: Add Image::updateConcreteSize()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.html

Issue 1694263003: Add Image::updateConcreteSize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-size-calculation-in

Patch Set: Add some documentation and polish title of test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing.html ('k') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('j') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Sizing SVG image when drawn to canvas</title>

	3 <script>

	4 function createCircle(x, y, r, sx, sy)

	5 {

	6 sx = typeof sx !== 'undefined' ? sx : 1;
	fs 2016/02/23 11:44:23 Nit: Assuming we don't intend to pass 0, then mayb Nit: Assuming we don't intend to pass 0, then maybe just "sx \|\| 1" at the point where it's used? davve 2016/02/23 13:15:30 Fixed in dependent CL. Show quoted text On 2016/02/23 11:44:23, fs wrote: > Nit: Assuming we don't intend to pass 0, then maybe just "sx \|\| 1" at the point > where it's used? Fixed in dependent CL.
	7 sy = typeof sy !== 'undefined' ? sy : 1;

	8

	9 var canvas = document.createElement('canvas');

	10 canvas.width = 100;

	11 canvas.height = 100;

	12 document.documentElement.appendChild(canvas);

	13

	14 var ctx = canvas.getContext('2d');

	15 ctx.fillStyle = "blue";

	16

	17 ctx.translate(50, 50);

	18 ctx.scale(sx, sy);

	19 ctx.beginPath();

	20 ctx.arc(x, y, r, 0, 2*Math.PI);

	21 ctx.fill();

	22 }

	23 createCircle(0, 0, 50);

	24 createCircle(0, -25, 25);

	25 createCircle(-25, 0, 25);

	26 createCircle(0, 0, 25, 1, 2);

	27 createCircle(0, 0, 25, 2, 1);

	28 createCircle(-25, 0, 25);

	29 createCircle(0, -25, 25);

	30 createCircle(0, -25, 25);

	31 </script>

OLD	NEW