Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: content/browser/cache_storage/cache_storage_cache.cc

Issue 1694213002: CacheStorage: Add ignoreSearch option to cache.delete(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary check Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cache_storage/cache_storage_cache.cc
diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc
index e037dbf33d176297d3bb7a9e8c172a6d3912ee66..0c9a85af10e9e1335df76d22b30cc8875c861830 100644
--- a/content/browser/cache_storage/cache_storage_cache.cc
+++ b/content/browser/cache_storage/cache_storage_cache.cc
@@ -813,7 +813,7 @@ void CacheStorageCache::PutImpl(scoped_ptr<PutContext> put_context) {
scoped_ptr<ServiceWorkerFetchRequest> request_copy(
new ServiceWorkerFetchRequest(*put_context->request));
- DeleteImpl(std::move(request_copy),
+ DeleteImpl(std::move(request_copy), CacheStorageCacheQueryParams(),
base::Bind(&CacheStorageCache::PutDidDelete,
weak_ptr_factory_.GetWeakPtr(),
base::Passed(std::move(put_context))));
@@ -1035,17 +1035,27 @@ void CacheStorageCache::Delete(const CacheStorageBatchOperation& operation,
weak_ptr_factory_.GetWeakPtr(), callback);
scheduler_->ScheduleOperation(
base::Bind(&CacheStorageCache::DeleteImpl, weak_ptr_factory_.GetWeakPtr(),
- base::Passed(std::move(request)), pending_callback));
+ base::Passed(std::move(request)), operation.match_params,
+ pending_callback));
}
void CacheStorageCache::DeleteImpl(
scoped_ptr<ServiceWorkerFetchRequest> request,
+ const CacheStorageCacheQueryParams& match_params,
const ErrorCallback& callback) {
DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
if (backend_state_ != BACKEND_OPEN) {
callback.Run(CACHE_STORAGE_ERROR_STORAGE);
return;
}
+
+ if (match_params.ignore_search) {
+ OpenAllEntries(base::Bind(&CacheStorageCache::DeleteDidOpenAllEntries,
+ weak_ptr_factory_.GetWeakPtr(),
+ base::Passed(std::move(request)), callback));
+ return;
+ }
+
scoped_ptr<disk_cache::Entry*> entry(new disk_cache::Entry*);
disk_cache::Entry** entry_ptr = entry.get();
@@ -1063,6 +1073,30 @@ void CacheStorageCache::DeleteImpl(
open_entry_callback.Run(rv);
}
+void CacheStorageCache::DeleteDidOpenAllEntries(
+ scoped_ptr<ServiceWorkerFetchRequest> request,
+ const ErrorCallback& callback,
+ scoped_ptr<OpenAllEntriesContext> entries_context,
+ CacheStorageError error) {
+ if (error != CACHE_STORAGE_OK) {
+ callback.Run(error);
+ return;
+ }
+
+ GURL request_url_without_query = RemoveQueryParam(request->url);
+ for (Entries::iterator iter = entries_context->entries.begin();
+ iter != entries_context->entries.end(); iter++) {
+ disk_cache::Entry* entry(*iter);
+ if (request_url_without_query == RemoveQueryParam(GURL(entry->GetKey())))
+ entry->Doom();
+ }
+
+ entries_context.reset();
+
+ UpdateCacheSize();
+ callback.Run(CACHE_STORAGE_OK);
+}
+
void CacheStorageCache::DeleteDidOpenEntry(
const GURL& origin,
scoped_ptr<ServiceWorkerFetchRequest> request,
« no previous file with comments | « content/browser/cache_storage/cache_storage_cache.h ('k') | content/browser/cache_storage/cache_storage_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698