CacheStorage: Add ignoreSearch option to cache.delete().

content/browser/cache_storage/cache_storage_cache_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/cache_storage/cache_storage_cache.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
@@ skipping 390 matching lines @@
     loop.Run();
     return callback_error_ == CACHE_STORAGE_OK;
   }
 
   bool MatchAll(scoped_ptr<CacheStorageCache::Responses>* responses,
                 scoped_ptr<CacheStorageCache::BlobDataHandles>* body_handles) {
     return MatchAll(ServiceWorkerFetchRequest(), CacheStorageCacheQueryParams(),
                     responses, body_handles);
   }
 
-  bool Delete(const ServiceWorkerFetchRequest& request) {
+  bool Delete(const ServiceWorkerFetchRequest& request,
+              const CacheStorageCacheQueryParams& match_params =
+                  CacheStorageCacheQueryParams()) {

[jkarlin, 2016/02/24 16:35:34]

I see that default arguments are now allowed by the style guide, cool.

     CacheStorageBatchOperation operation;
     operation.operation_type = CACHE_STORAGE_CACHE_OPERATION_TYPE_DELETE;
     operation.request = request;
+    operation.match_params = match_params;
 
     CacheStorageError error =
         BatchOperation(std::vector<CacheStorageBatchOperation>(1, operation));
     return error == CACHE_STORAGE_OK;
   }
 
   bool Keys() {
     scoped_ptr<base::RunLoop> loop(new base::RunLoop());
 
     cache_->Keys(base::Bind(&CacheStorageCacheTest::RequestsCallback,
@@ skipping 604 matching lines @@
   EXPECT_TRUE(Delete(no_body_request_));
   EXPECT_EQ(0, Size());
 
   EXPECT_TRUE(Put(body_request_, body_response_));
   EXPECT_LT(no_body_size, Size());
 
   EXPECT_TRUE(Delete(body_request_));
   EXPECT_EQ(0, Size());
 }
 
+TEST_P(CacheStorageCacheTestP, DeleteWithIgnoreSearch) {
+  EXPECT_EQ(0, Size());
+  EXPECT_TRUE(Put(no_body_request_, no_body_response_));
+  EXPECT_LT(0, Size());

[jkarlin, 2016/02/24 16:35:34]

Prefer to use Keys() instead of Size() in this test to determine exactly what is
in the cache. 

[zino, 2016/02/24 18:05:21]

Done.

+  int64_t no_body_size = Size();
+
+  EXPECT_TRUE(Put(body_request_, body_response_));
+  EXPECT_TRUE(Put(body_request_with_query_, body_response_with_query_));
+  EXPECT_LT(no_body_size, Size());
+
+  CacheStorageCacheQueryParams match_params;
+  match_params.ignore_search = true;
+
+  // The following delete operation will remove both of body_reqeust_ and

[jkarlin, 2016/02/24 16:35:34]

typo: s/body_reqeust_/body_request_/

[zino, 2016/02/24 18:05:21]

Nice catch!

Thank you.

Done.

+  // body_request_with_query_ from cache storage.
+  EXPECT_TRUE(Delete(body_request_with_query_, match_params));
+
+  EXPECT_EQ(no_body_size, Size());
+}

[jkarlin, 2016/02/24 16:35:34]

Add a second test that deletes with default options to verify that only one is
deleted.

[zino, 2016/02/24 18:05:21]

Done.

+
 TEST_P(CacheStorageCacheTestP, OpsFailOnClosedBackendNeverCreated) {
   cache_->set_delay_backend_creation(
       true);  // Will hang the test if a backend is created.
   EXPECT_TRUE(Close());
   VerifyAllOpsFail();
 }
 
 TEST_P(CacheStorageCacheTestP, OpsFailOnClosedBackend) {
   // Create the backend and put something in it.
   EXPECT_TRUE(Put(body_request_, body_response_));
@@ skipping 45 matching lines @@
   EXPECT_EQ(1, sequence_out);
   close_loop2->Run();
   EXPECT_EQ(2, sequence_out);
 }
 
 INSTANTIATE_TEST_CASE_P(CacheStorageCacheTest,
                         CacheStorageCacheTestP,
                         ::testing::Values(false, true));
 
 }  // namespace content