Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1694183003: Use explicit context translation in CodeStub deoptimization (Closed)

Created:
4 years, 10 months ago by danno
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use explicit context translation in CodeStub deoptimization Before this CL, the context of the parent frame was used when deoptimizing a stub failure rather than the context value passed to the stub itself. In order to guarantee that the right context is passed to the runtime upon stub failure, this CL adds the context explicitly to the stub's environment that's used to compute the failure deoptimizing translations. The context can then be extracted during deoptimization translation to ensure that the precise context that was passed to the stub is also passed to the runtime. R=jarin@chromium.org LOG=N Committed: https://crrev.com/3aa2dd34f76bed92e7f2c7cff3e6f7ff7f9881e4 Cr-Commit-Position: refs/heads/master@{#34030}

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danno
PTAL
4 years, 10 months ago (2016-02-16 07:00:43 UTC) #1
Jarin
lgtm
4 years, 10 months ago (2016-02-16 09:46:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694183003/40001
4 years, 10 months ago (2016-02-16 11:15:55 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-16 11:47:57 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 11:48:20 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3aa2dd34f76bed92e7f2c7cff3e6f7ff7f9881e4
Cr-Commit-Position: refs/heads/master@{#34030}

Powered by Google App Engine
This is Rietveld 408576698