Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169413002: Removing unnecessary creation of RenderViewHostDestructionObserver for all WebContents (Closed)

Created:
6 years, 10 months ago by ckulakowski
Modified:
6 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing unnecessary creation of RenderViewHostDestructionObserver for all WebContents ProcessManager creates RenderViewHostDestructionObserver for all WebContents. It's not necessary as ProcessManager keeps information about WebContents only related to extensions (extension's background page, extension's popup). BUG=344297 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M extensions/browser/process_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/browser/process_manager.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ckulakowski
There is no need to create RenderViewHostDestructionObserver for WebContents which do not represent extension. In ...
6 years, 10 months ago (2014-02-17 10:08:38 UTC) #1
benwells
lgtm
6 years, 10 months ago (2014-02-17 23:52:30 UTC) #2
ckulakowski
The CQ bit was checked by ckulakowski@opera.com
6 years, 10 months ago (2014-02-18 06:47:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckulakowski@opera.com/169413002/1
6 years, 10 months ago (2014-02-18 06:47:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 07:50:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265461
6 years, 10 months ago (2014-02-18 07:50:09 UTC) #6
ckulakowski
The CQ bit was checked by ckulakowski@opera.com
6 years, 10 months ago (2014-02-18 08:59:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckulakowski@opera.com/169413002/1
6 years, 10 months ago (2014-02-18 08:59:23 UTC) #8
ckulakowski
The CQ bit was unchecked by ckulakowski@opera.com
6 years, 10 months ago (2014-02-18 08:59:30 UTC) #9
ckulakowski
The CQ bit was checked by ckulakowski@opera.com
6 years, 10 months ago (2014-02-18 10:21:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckulakowski@opera.com/169413002/1
6 years, 10 months ago (2014-02-18 10:21:15 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 16:22:26 UTC) #12
Message was sent while issue was closed. 
Change committed as 251765

Powered by Google App Engine
This is Rietveld 408576698