Use GURLS instead of patterns in SetCookieSetting()

chrome/browser/android/preferences/website_preference_bridge.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/preferences/website_preference_bridge.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/bind.h"
@@ skipping 453 matching lines @@
                                       jboolean is_incognito) {
   GURL url(ConvertJavaStringToUTF8(env, origin));
   ContentSettingsPattern primary_pattern(
       ContentSettingsPattern::FromURLNoWildcard(url));
   ContentSettingsPattern secondary_pattern(ContentSettingsPattern::Wildcard());
   ContentSetting setting = CONTENT_SETTING_DEFAULT;
   if (value == -1) {
     GetCookieSettings()->ResetCookieSetting(primary_pattern, secondary_pattern);
   } else {
     setting = value ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK;
-    GetCookieSettings()->SetCookieSetting(primary_pattern, secondary_pattern,
-                                          setting);
+    Profile* profile = ProfileManager::GetActiveUserProfile();
+    HostContentSettingsMapFactory::GetForProfile(profile)->SetContentSetting(
+        primary_pattern, secondary_pattern, CONTENT_SETTINGS_TYPE_COOKIES,
+        std::string(), setting);

[raymes, 2016/03/16 03:24:11]

I wonder if we should add a function to GetCookieSettings: AddException or
something which takes patterns?

[lshang, 2016/03/17 01:53:59]

Done.

   }
   WebSiteSettingsUmaUtil::LogPermissionChange(
       CONTENT_SETTINGS_TYPE_NOTIFICATIONS, setting);

[raymes, 2016/03/16 03:24:11]

nit: this looks wrong!

[lshang, 2016/03/17 01:53:59]

Done.⊙▂⊙

 }
 
 static jboolean IsContentSettingsPatternValid(
     JNIEnv* env,
     const JavaParamRef<jclass>& clazz,
     const JavaParamRef<jstring>& pattern) {
   return ContentSettingsPattern::FromString(
       ConvertJavaStringToUTF8(env, pattern)).IsValid();
 }
 
@@ skipping 276 matching lines @@
   GURL url(ConvertJavaStringToUTF8(env, jorigin));
   scoped_refptr<SiteDataDeleteHelper> site_data_deleter(
       new SiteDataDeleteHelper(profile, url));
   site_data_deleter->Run();
 }
 
 // Register native methods
 bool RegisterWebsitePreferenceBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }