Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 169403008: Add a <viewer-password-screen> element. (Closed)

Created:
6 years, 10 months ago by raymes
Modified:
6 years, 10 months ago
Reviewers:
ganetsky1
CC:
ganetsky1, Jelte, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/html-office-public.git@master
Visibility:
Public.

Description

Add a <viewer-password-screen> element. This element displays a password entry screen to collect a password from the user. It fires a 'password' event when a password is entered. It exposes accept() and deny() methods which can be called to indicate the password was accepted or denied. It also exposes an 'active' attribute which specifies whether or not the password screen is visible. BUG=303491 R=ganetsky@chromium.org Committed: 7c5a97b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
A elements/viewer-password-screen/viewer-password-screen.css View 1 chunk +41 lines, -0 lines 0 comments Download
A elements/viewer-password-screen/viewer-password-screen.html View 1 chunk +65 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
raymes
6 years, 10 months ago (2014-02-19 00:14:30 UTC) #1
ganetsky1
lgtm https://codereview.chromium.org/169403008/diff/1/elements/viewer-password-screen/viewer-password-screen.html File elements/viewer-password-screen/viewer-password-screen.html (right): https://codereview.chromium.org/169403008/diff/1/elements/viewer-password-screen/viewer-password-screen.html#newcode51 elements/viewer-password-screen/viewer-password-screen.html:51: if (this.active) { You can add arguments oldValue ...
6 years, 10 months ago (2014-02-20 20:18:16 UTC) #2
raymes
On 2014/02/20 20:18:16, ganetsky1 wrote: > lgtm > > https://codereview.chromium.org/169403008/diff/1/elements/viewer-password-screen/viewer-password-screen.html > File elements/viewer-password-screen/viewer-password-screen.html (right): > ...
6 years, 10 months ago (2014-02-21 00:36:35 UTC) #3
raymes
6 years, 10 months ago (2014-02-21 00:48:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r7c5a97b.

Powered by Google App Engine
This is Rietveld 408576698