Fix naming typo: Settings.TrackedSplitPreferenceChanged => Settings.TrackedSplitPreferenceChangedCo…

Fix naming typo for Settings.TrackedSplitPreferenceChanged.

It was meant to be named Settings.TrackedSplitPreferenceChangedCount, but a typo was introduced in the code to Settings.TrackedSplitPreferenceChanged; it's now easier to keep the typo'ed name, making histograms.xml use it as well.

NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251764

[gab, 2014-02-17 20:15:57]

TBR asvitkine.

@Alexei: is there any easy way to rename the reports we got so far under the
typo'ed name to get retroactive data?

Thanks!
Gab

[gab, 2014-02-17 20:16:33]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-02-17 20:16:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/169403007/30001

[Alexei Svitkine (slow), 2014-02-17 20:45:10]

On 2014/02/17 20:16:46, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/gab%40chromium.org/169403007/30001

not lgtm

Can't you just rename the histograms.xml entries?

[Alexei Svitkine (slow), 2014-02-17 20:45:29]

The CQ bit was unchecked by asvitkine@chromium.org

[gab, 2014-02-17 22:01:00]

On 2014/02/17 20:45:10, Alexei Svitkine wrote:
> On 2014/02/17 20:16:46, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/gab%2540chromium.org/169403007/30001
> 
> not lgtm
> 
> Can't you just rename the histograms.xml entries?

Hmm I could, but Settings.TrackedSplitPreferenceChangedCount is the name I want;
the one in the feature code is missing "Count" (by mistake) and I feel the name
without "Count" doesn't convey well what this stat is (i.e., a count!).

Worst case we lose the stats gathered so far for this stat (only on canary/dev);
best case we can rename the stats gathered/computed server side (but if that's
not possible, I'm okay with losing the data).

[Alexei Svitkine (slow), 2014-02-17 23:01:48]

On 2014/02/17 22:01:00, gab wrote:
> On 2014/02/17 20:45:10, Alexei Svitkine wrote:
> > On 2014/02/17 20:16:46, I haz the power (commit-bot) wrote:
> > > CQ is trying da patch. Follow status at
> > >
https://chromium-status.appspot.com/cq/gab%252540chromium.org/169403007/30001
> > 
> > not lgtm
> > 
> > Can't you just rename the histograms.xml entries?
> 
> Hmm I could, but Settings.TrackedSplitPreferenceChangedCount is the name I
want;
> the one in the feature code is missing "Count" (by mistake) and I feel the
name
> without "Count" doesn't convey well what this stat is (i.e., a count!).
> 
> Worst case we lose the stats gathered so far for this stat (only on
canary/dev);
> best case we can rename the stats gathered/computed server side (but if that's
> not possible, I'm okay with losing the data).

I don't think you should worry so much about the name. As long as the histogram
description is clear about what it does, I think the existing name is fine.

If you really do want to rename it, the right way to go about it is to add an
entry for the old histogram name to histograms.xml and mark as Obsolete,
documenting when it got renamed to the new name. (This is because we don't want
to have unknown data in UMA - all histogram hashes should be able to be mapped
to actual names.) But at that point, if you'll need to document the old
histogram anyway, it seems simpler to just keep the name the same and update the
XML file to refer to it.

[gab, 2014-02-18 03:06:09]

On 2014/02/17 23:01:48, Alexei Svitkine wrote:
> On 2014/02/17 22:01:00, gab wrote:
> > On 2014/02/17 20:45:10, Alexei Svitkine wrote:
> > > On 2014/02/17 20:16:46, I haz the power (commit-bot) wrote:
> > > > CQ is trying da patch. Follow status at
> > > >
>
https://chromium-status.appspot.com/cq/gab%25252540chromium.org/169403007/30001
> > > 
> > > not lgtm
> > > 
> > > Can't you just rename the histograms.xml entries?
> > 
> > Hmm I could, but Settings.TrackedSplitPreferenceChangedCount is the name I
> want;
> > the one in the feature code is missing "Count" (by mistake) and I feel the
> name
> > without "Count" doesn't convey well what this stat is (i.e., a count!).
> > 
> > Worst case we lose the stats gathered so far for this stat (only on
> canary/dev);
> > best case we can rename the stats gathered/computed server side (but if
that's
> > not possible, I'm okay with losing the data).
> 
> I don't think you should worry so much about the name. As long as the
histogram
> description is clear about what it does, I think the existing name is fine.
> 
> If you really do want to rename it, the right way to go about it is to add an
> entry for the old histogram name to histograms.xml and mark as Obsolete,
> documenting when it got renamed to the new name. (This is because we don't
want
> to have unknown data in UMA - all histogram hashes should be able to be mapped
> to actual names.) But at that point, if you'll need to document the old
> histogram anyway, it seems simpler to just keep the name the same and update
the
> XML file to refer to it.

Okay sounds good, sorry for trying to commit in a rush; I wanted to get the
right name in before branch cut; renaming the histograms themselves in
histograms.xml is not as urgent, I'll get to it tomorrow.

Once the histograms in histograms.xml are renamed; will we be getting
retroactive data?

[Alexei Svitkine (slow), 2014-02-18 03:27:51]

On 2014/02/18 03:06:09, gab wrote:
> Once the histograms in histograms.xml are renamed; will we be getting
> retroactive data?

Yes - all the previous data will be visible.

[gab, 2014-02-18 13:55:37]

Thanks for the info, PTAL.

Cheers,
Gab

[Alexei Svitkine (slow), 2014-02-18 15:08:26]

lgtm

[gab, 2014-02-18 15:11:58]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-02-18 15:12:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/169403007/130001

[commit-bot: I haz the power, 2014-02-18 16:21:49]

Change committed as 251764