command_buffer: Implement path rendering functions for CHROMIUM_path_rendering

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 191 matching lines @@
 
   feature_flags_.is_swiftshader =
       (command_line.GetSwitchValueASCII(switches::kUseGL) == "swiftshader");
 
   feature_flags_.enable_subscribe_uniform =
       command_line.HasSwitch(switches::kEnableSubscribeUniformExtension);
 
   enable_unsafe_es3_apis_switch_ =
       command_line.HasSwitch(switches::kEnableUnsafeES3APIs);
 
+  enable_gl_path_rendering_switch_ =
+      command_line.HasSwitch(switches::kEnableGLPathRendering);
+
   unsafe_es3_apis_enabled_ = false;
 }
 
 bool FeatureInfo::Initialize() {
   disallowed_features_ = DisallowedFeatures();
   InitializeFeatures();
   return true;
 }
 
 bool FeatureInfo::Initialize(const DisallowedFeatures& disallowed_features) {
@@ skipping 775 matching lines @@
       if (blend_equation_advanced_coherent)
         AddExtensionString("GL_KHR_blend_equation_advanced_coherent");
 
       AddExtensionString("GL_KHR_blend_equation_advanced");
       feature_flags_.blend_equation_advanced = true;
       feature_flags_.blend_equation_advanced_coherent =
           blend_equation_advanced_coherent;
     }
   }
 
-  if (extensions.Contains("GL_NV_path_rendering")) {
-    if (extensions.Contains("GL_EXT_direct_state_access") ||
-        gl_version_info_->is_es3) {
+  if (enable_gl_path_rendering_switch_ &&
+      extensions.Contains("GL_NV_path_rendering")) {
+    bool hasNeededOptionalFunctions =
+        gfx::GetGLProcAddress("glStencilThenCoverFillPathNV") &&
+        gfx::GetGLProcAddress("glStencilThenCoverStrokePathNV");

[piman, 2015/06/27 01:20:07]

Why is this needed?

[Kimmo Kinnunen, 2015/06/29 05:46:04]

These required functions are part of the API version 1.2.  For
older drivers, these do not exist, even though the extension
string is the same. In theory these particular functions could be simulated if
missing. In patch #3 of the patchset, texturing, there will be use of API
version 1.3, which can not be simulated. This is why I did not implement the
simulation.

[piman, 2015/06/29 23:31:17]

I don't much like this idea of extension "API version"... It sounds like older
drivers are exposing an extension string without implementing the extension as
documented on the registry
(https://www.khronos.org/registry/gles/extensions/NV/path_rendering.txt), which
is really a driver bug.

I would actually prefer if we blacklisted the extension on older driver versions
using the workarounds mechanism (gpu/config/gpu_driver_bug_list_json.cc). This
is fragile, we mock the GetProcAddress function in some environments.

+
+    if (hasNeededOptionalFunctions &&
+        (extensions.Contains("GL_EXT_direct_state_access") ||
+         gl_version_info_->is_es3)) {
       AddExtensionString("GL_CHROMIUM_path_rendering");
       feature_flags_.chromium_path_rendering = true;
       validators_.g_l_state.AddValue(GL_PATH_MODELVIEW_MATRIX_CHROMIUM);
       validators_.g_l_state.AddValue(GL_PATH_PROJECTION_MATRIX_CHROMIUM);
+      validators_.g_l_state.AddValue(GL_PATH_STENCIL_FUNC_CHROMIUM);
+      validators_.g_l_state.AddValue(GL_PATH_STENCIL_REF_CHROMIUM);
+      validators_.g_l_state.AddValue(GL_PATH_STENCIL_VALUE_MASK_CHROMIUM);
     }
   }
 
   if ((gl_version_info_->is_es3 || gl_version_info_->is_desktop_core_profile ||
        extensions.Contains("GL_EXT_texture_rg") ||
        extensions.Contains("GL_ARB_texture_rg")) &&
       IsGL_REDSupportedOnFBOs()) {
     feature_flags_.ext_texture_rg = true;
     AddExtensionString("GL_EXT_texture_rg");
 
@@ skipping 109 matching lines @@
   if (pos == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu