Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: src/a64/regexp-macro-assembler-a64.cc

Issue 169403003: A64: Replace a Cmp/Branch sequence by a conditional compare. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/regexp-macro-assembler-a64.cc
diff --git a/src/a64/regexp-macro-assembler-a64.cc b/src/a64/regexp-macro-assembler-a64.cc
index 00558c017b9cecf82b67706ce40a95abbf021930..b162b38bde686c0cb93de9f29d6155c9e6642d1f 100644
--- a/src/a64/regexp-macro-assembler-a64.cc
+++ b/src/a64/regexp-macro-assembler-a64.cc
@@ -363,11 +363,9 @@ void RegExpMacroAssemblerA64::CheckNotBackReferenceIgnoreCase(
__ B(ls, &loop_check); // In range 'a'-'z'.
// Latin-1: Check for values in range [224,254] but not 247.
__ Sub(w10, w10, 224 - 'a');
- // TODO(jbramley): Use Ccmp here.
__ Cmp(w10, 254 - 224);
- __ B(hi, &fail); // Weren't Latin-1 letters.
- __ Cmp(w10, 247 - 224); // Check for 247.
- __ B(eq, &fail);
+ __ Ccmp(w10, 247 - 224, ZFlag, ls); // Check for 247.
+ __ B(eq, &fail); // Weren't Latin-1 letters.
__ Bind(&loop_check);
__ Cmp(capture_start_address, capture_end_addresss);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698