Revert "Change isBlock and isInline functions to check for isElementNode"

Revert "Change isBlock and isInline functions to check for isElementNode"

This reverts commit 6415003fe8070545c67d82f88c69512bd38b2f9f.
isElementNode() check added in isBlock() introduced a crash.
Hence reverting the same.

BUG=341783
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167362

[vanihegde, 2014-02-17 09:12:56]

Before this patch, Document node was being considered as a Block Node by
isBlock().

Because of the isElementNode() check added in this patch, Document node is no
longer considered as a Block Node by isBlock().

This could be fixed by changing the isBlock() & enclosingBlock() implementations
as below:
bool isBlock(const Node* node)
{
    return node && (node->isElementNode() || node->isDocumentNode()) &&
node->renderer() && !node->renderer()->isInline() &&
!node->renderer()->isRubyText();
}

Element* enclosingBlock(Node* node, EditingBoundaryCrossingRule rule)
{
    Node* enclosingNode = enclosingNodeOfType(firstPositionInOrBeforeNode(node),
isBlock, rule);
    return enclosingNode && !enclosingNode->isDocumentNode() ?
toElement(enclosingNode) : 0;
}

But not sure if its right to do so! Hence reverting the change for now.
Opinions?

[ojan, 2014-02-18 19:07:19]

lgtm

[commit-bot: I haz the power, 2014-02-18 19:08:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/169403002/1

[commit-bot: I haz the power, 2014-02-18 21:38:49]

Change committed as 167362