Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2152)

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 16940009: [Android WebView] Implement WebPermissionClient methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/aw_render_view_ext.cc
diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc
index 8452b458f05621bfd606c004db669942927a94ac..8f1b8b0eca3fc9d903cf277d59cb486512d524d6 100644
--- a/android_webview/renderer/aw_render_view_ext.cc
+++ b/android_webview/renderer/aw_render_view_ext.cc
@@ -34,6 +34,15 @@ namespace android_webview {
namespace {
+bool allowMixedContent(const WebKit::WebURL& url) {
joth 2013/06/13 19:16:28 nit: wrong Camelification
+ // We treat non-standard schemes as "secure" in the WebView to allow them to
+ // be used for request interception.
+ // TODO(benm): Tighten this restriction by requiring embedders to register
+ // their custom schemes? See b/9420953.
+ GURL gurl(url);
+ return !gurl.IsStandard();
+}
+
GURL GetAbsoluteUrl(const WebKit::WebNode& node, const string16& url_fragment) {
return GURL(node.document().completeURL(url_fragment));
}
@@ -182,6 +191,22 @@ bool AwRenderViewExt::allowImage(WebKit::WebFrame* frame,
url.SchemeIs(chrome::kFtpScheme));
}
+bool AwRenderViewExt::allowDisplayingInsecureContent(
+ WebKit::WebFrame* frame,
+ bool enabled_per_settings,
+ const WebKit::WebSecurityOrigin& origin,
+ const WebKit::WebURL& url) {
+ return enabled_per_settings ? true : allowMixedContent(url);
+}
+
+bool AwRenderViewExt::allowRunningInsecureContent(
+ WebKit::WebFrame* frame,
+ bool enabled_per_settings,
+ const WebKit::WebSecurityOrigin& origin,
+ const WebKit::WebURL& url) {
+ return enabled_per_settings ? true : allowMixedContent(url);
+}
+
void AwRenderViewExt::DidCommitProvisionalLoad(WebKit::WebFrame* frame,
bool is_new_navigation) {
content::DocumentState* document_state =
« no previous file with comments | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698