Issue 16940009: [Android WebView] Implement WebPermissionClient methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16940009: [Android WebView] Implement WebPermissionClient methods. (Closed)

Created:
7 years, 6 months ago by benm (inactive)

Modified:
7 years, 6 months ago

Reviewers:
joth, mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android WebView] Implement WebPermissionClient methods. Add an implementation of allowDisplayingInsecureContent and allowRunningInsecureContent that allows secure content to load content using a custom scheme. BUG=b/9420953 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206244

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix style #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	android_webview/renderer/aw_render_view_ext.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
	M	android_webview/renderer/aw_render_view_ext.cc	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

joth

lgtm minor grumble about b/ link in code comments but it makes little practical odds ...

7 years, 6 months ago (2013-06-13 19:16:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/16940009/6001

7 years, 6 months ago (2013-06-13 19:52:10 UTC) #4

Message was sent while issue was closed.

Change committed as 206244

Expand Messages | Collapse Messages