Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Unified Diff: bin/sync-and-gyp

Issue 1693963005: bin/sync-and-gyp: start using gclient (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-02-16 (Tuesday) 12:14:21 EST Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gitignore ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/sync-and-gyp
diff --git a/bin/sync-and-gyp b/bin/sync-and-gyp
index 80dead97583504399f7cbe32b5692482eba1dbd7..fadfff84e941429a685a7b98860fdcd12e1005f0 100755
--- a/bin/sync-and-gyp
+++ b/bin/sync-and-gyp
@@ -8,10 +8,12 @@
# This script will update Skia's dependencies as necessary and run
# gyp if needed.
-# Depends on: Python, and Git.
+# Depends on: Python, Git, and depot_tools.
#
# Example usage:
#
+# git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
+# export PATH="${PWD}/depot_tools:${PATH}"
# git clone https://skia.googlesource.com/skia
# cd skia
# python bin/sync-and-gyp
@@ -41,9 +43,42 @@ if not os.path.isfile('DEPS'):
sys.stderr.write('DEPS file missing')
exit(1)
-env = os.environ.copy()
-env["GIT_SYNC_DEPS_QUIET"] = "1"
-subprocess.call(['python', 'tools/git-sync-deps'], env=env)
+deps_hasher = hashlib.sha1()
+with open('DEPS', 'r') as f:
+ deps_hasher.update(f.read())
+deps_hash = deps_hasher.hexdigest()
+current_deps_hash = None
+if os.path.isfile('.deps_sha1'):
+ with open('.deps_sha1', 'r') as f:
+ current_deps_hash = f.read().strip()
+
+default_gclient_config = '''
+solutions = [
+ { "name" : ".",
+ "url" : "https://skia.googlesource.com/skia.git",
+ "deps_file" : "DEPS",
+ "managed" : False,
+ "custom_deps" : {
+ },
+ "safesync_url": "",
+ },
+]
+cache_dir = None
+'''
+if current_deps_hash != deps_hash:
+ # `gclient sync` is very slow, so skip whenever we can.
+ if not os.path.isfile('.gclient'):
+ with open('.gclient', 'w') as o:
+ o.write(default_gclient_config)
+ try:
+ subprocess.check_call(['gclient', 'sync'])
+ except:
+ sys.stderr.write('\n`gclient sync` failed.\n')
kjlubick 2016/02/17 13:57:04 Drive by comment, sys is not defined.
+ os.remove('.deps_sha1') # Unknown state.
+ exit(1)
+ # Only write hash after a successful sync.
+ with open('.deps_sha1', 'w') as o:
+ o.write(deps_hash)
hasher = hashlib.sha1()
« no previous file with comments | « .gitignore ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698