Chromium Code Reviews| Index: src/compiler/x64/instruction-selector-x64.cc |
| diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc |
| index 96f8e32f8d607d7f95692bbeb4615137261da3a6..79d08160b1a0f0e58b8aff4ae6ebdc12f006b0f5 100644 |
| --- a/src/compiler/x64/instruction-selector-x64.cc |
| +++ b/src/compiler/x64/instruction-selector-x64.cc |
| @@ -130,7 +130,8 @@ void InstructionSelector::VisitLoad(Node* node) { |
| opcode = kX64Movl; |
| break; |
| case MachineRepresentation::kTagged: // Fall through. |
| - case MachineRepresentation::kWord64: |
| + case MachineRepresentation::kWord64: // Fall through. |
| + case MachineRepresentation::kSimd128: |
|
titzer
2016/02/17 11:57:02
Probably want to make this case unreachable for no
bbudge
2016/02/17 18:57:14
Done.
|
| opcode = kX64Movq; |
| break; |
| case MachineRepresentation::kNone: |
| @@ -216,7 +217,8 @@ void InstructionSelector::VisitStore(Node* node) { |
| opcode = kX64Movl; |
| break; |
| case MachineRepresentation::kTagged: // Fall through. |
| - case MachineRepresentation::kWord64: |
| + case MachineRepresentation::kWord64: // Fall through. |
| + case MachineRepresentation::kSimd128: |
|
Jarin
2016/02/17 12:06:47
Preferably move this case to the unreachable case,
bbudge
2016/02/17 18:57:14
Done.
|
| opcode = kX64Movq; |
| break; |
| case MachineRepresentation::kNone: |
| @@ -264,8 +266,9 @@ void InstructionSelector::VisitCheckedLoad(Node* node) { |
| case MachineRepresentation::kFloat64: |
| opcode = kCheckedLoadFloat64; |
| break; |
| - case MachineRepresentation::kBit: |
| - case MachineRepresentation::kTagged: |
| + case MachineRepresentation::kBit: // Fall through. |
| + case MachineRepresentation::kSimd128: // Fall through. |
| + case MachineRepresentation::kTagged: // Fall through. |
| case MachineRepresentation::kNone: |
| UNREACHABLE(); |
| return; |
| @@ -316,8 +319,9 @@ void InstructionSelector::VisitCheckedStore(Node* node) { |
| case MachineRepresentation::kFloat64: |
| opcode = kCheckedStoreFloat64; |
| break; |
| - case MachineRepresentation::kBit: |
| - case MachineRepresentation::kTagged: |
| + case MachineRepresentation::kBit: // Fall through. |
| + case MachineRepresentation::kSimd128: // Fall through. |
| + case MachineRepresentation::kTagged: // Fall through. |
| case MachineRepresentation::kNone: |
| UNREACHABLE(); |
| return; |