chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc - Issue 1693963003: Pass origin to StartObservingMediaSinks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

Issue 1693963003: Pass origin to StartObservingMediaSinks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready for Review Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/media_source_helper.cc ('K') | « chrome/browser/media/router/presentation_media_sinks_observer.cc ('k') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('j') | chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

diff --git a/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc b/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

index 21220b46ffef015b587bd1c1de2c035db545eee4..ca114bcf7931ac186281153cbb7ad653385e4755 100644

--- a/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

+++ b/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

@@ -29,7 +29,8 @@ class PresentationMediaSinksObserverTest : public ::testing::Test {

EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).WillOnce(Return(true));

observer_.reset(new PresentationMediaSinksObserver(

&router_, &listener_,

- MediaSourceForPresentationUrl("http://example.com/presentation.html")));

+ MediaSourceForPresentationUrl("http://example.com/presentation.html"),

+ GURL("http://example.com/presentation.html")));

mark a. foltz 2016/02/17 21:50:51 Nit: This is not an origin; origin is scheme, host

matt.boetger 2016/02/18 00:50:33 Done.

EXPECT_TRUE(observer_->Init());

}