Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2365)

Unified Diff: chrome/browser/media/router/media_router_mojo_impl_unittest.cc

Issue 1693963003: Pass origin to StartObservingMediaSinks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ready for Review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_mojo_impl_unittest.cc
diff --git a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
index fe521ca1bffceeaf85475a988ae0c41f3f66e9bb..e861041df32e3b5e52625a02fa6aaa6c9416edb3 100644
--- a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
+++ b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
@@ -468,22 +468,25 @@ TEST_F(MediaRouterMojoImplTest, RegisterAndUnregisterMediaSinksObserver) {
router()->OnSinkAvailabilityUpdated(
interfaces::MediaRouter::SinkAvailability::AVAILABLE);
MediaSource media_source(kSource);
+ GURL origin(kOrigin);
// These should only be called once even if there is more than one observer
// for a given source.
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource)));
+ StartObservingMediaSinks(mojo::String(kSource),
+ mojo::String(kOrigin)));
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource2)));
+ StartObservingMediaSinks(mojo::String(kSource2),
+ mojo::String(kOrigin)));
scoped_ptr<MockMediaSinksObserver> sinks_observer(
- new MockMediaSinksObserver(router(), media_source));
+ new MockMediaSinksObserver(router(), media_source, origin));
EXPECT_TRUE(sinks_observer->Init());
scoped_ptr<MockMediaSinksObserver> extra_sinks_observer(
- new MockMediaSinksObserver(router(), media_source));
+ new MockMediaSinksObserver(router(), media_source, origin));
EXPECT_TRUE(extra_sinks_observer->Init());
scoped_ptr<MockMediaSinksObserver> unrelated_sinks_observer(
- new MockMediaSinksObserver(router(), MediaSource(kSource2)));
+ new MockMediaSinksObserver(router(), MediaSource(kSource2), origin));
EXPECT_TRUE(unrelated_sinks_observer->Init());
ProcessEventLoop();
@@ -518,7 +521,7 @@ TEST_F(MediaRouterMojoImplTest, RegisterAndUnregisterMediaSinksObserver) {
// |media_source|, return cached results to observers that are subsequently
// registered.
scoped_ptr<MockMediaSinksObserver> cached_sinks_observer(
- new MockMediaSinksObserver(router(), media_source));
+ new MockMediaSinksObserver(router(), media_source, origin));
EXPECT_CALL(*cached_sinks_observer,
OnSinksReceived(SequenceEquals(expected_sinks)));
EXPECT_TRUE(cached_sinks_observer->Init());
@@ -540,24 +543,27 @@ TEST_F(MediaRouterMojoImplTest, RegisterAndUnregisterMediaSinksObserver) {
TEST_F(MediaRouterMojoImplTest,
RegisterMediaSinksObserverWithAvailabilityChange) {
+ GURL origin(kOrigin);
// When availability is UNAVAILABLE, no calls should be made to MRPM.
router()->OnSinkAvailabilityUpdated(
interfaces::MediaRouter::SinkAvailability::UNAVAILABLE);
MediaSource media_source(kSource);
scoped_ptr<MockMediaSinksObserver> sinks_observer(
- new MockMediaSinksObserver(router(), media_source));
+ new MockMediaSinksObserver(router(), media_source, origin));
EXPECT_CALL(*sinks_observer, OnSinksReceived(IsEmpty()));
EXPECT_TRUE(sinks_observer->Init());
MediaSource media_source2(kSource2);
scoped_ptr<MockMediaSinksObserver> sinks_observer2(
- new MockMediaSinksObserver(router(), media_source2));
+ new MockMediaSinksObserver(router(), media_source2, origin));
EXPECT_CALL(*sinks_observer2, OnSinksReceived(IsEmpty()));
EXPECT_TRUE(sinks_observer2->Init());
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource)))
+ StartObservingMediaSinks(mojo::String(kSource),
+ mojo::String(kOrigin)))
.Times(0);
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource2)))
+ StartObservingMediaSinks(mojo::String(kSource2),
+ mojo::String(kOrigin)))
.Times(0);
ProcessEventLoop();
EXPECT_TRUE(Mock::VerifyAndClearExpectations(&mock_media_route_provider_));
@@ -567,10 +573,12 @@ TEST_F(MediaRouterMojoImplTest,
router()->OnSinkAvailabilityUpdated(
interfaces::MediaRouter::SinkAvailability::AVAILABLE);
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource)))
+ StartObservingMediaSinks(mojo::String(kSource),
+ mojo::String(kOrigin)))
.Times(1);
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource2)))
+ StartObservingMediaSinks(mojo::String(kSource2),
+ mojo::String(kOrigin)))
.Times(1);
ProcessEventLoop();
EXPECT_TRUE(Mock::VerifyAndClearExpectations(&mock_media_route_provider_));
@@ -579,10 +587,12 @@ TEST_F(MediaRouterMojoImplTest,
router()->OnSinkAvailabilityUpdated(
interfaces::MediaRouter::SinkAvailability::AVAILABLE);
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource)))
+ StartObservingMediaSinks(mojo::String(kSource),
+ mojo::String(kOrigin)))
.Times(0);
EXPECT_CALL(mock_media_route_provider_,
- StartObservingMediaSinks(mojo::String(kSource2)))
+ StartObservingMediaSinks(mojo::String(kSource2),
+ mojo::String(kOrigin)))
.Times(0);
ProcessEventLoop();
EXPECT_TRUE(Mock::VerifyAndClearExpectations(&mock_media_route_provider_));

Powered by Google App Engine
This is Rietveld 408576698