Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4108)

Unified Diff: chrome/browser/ui/webui/media_router/query_result_manager.h

Issue 1693963003: Pass origin to StartObservingMediaSinks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cache off media source Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/query_result_manager.h
diff --git a/chrome/browser/ui/webui/media_router/query_result_manager.h b/chrome/browser/ui/webui/media_router/query_result_manager.h
index f355b07d5acca7db49079ed984f77b093f9a62ee..b55be6aa7e311d1159cb203691fa0162a4939dff 100644
--- a/chrome/browser/ui/webui/media_router/query_result_manager.h
+++ b/chrome/browser/ui/webui/media_router/query_result_manager.h
@@ -39,9 +39,10 @@ struct SinksQueryResult;
// QueryResultManager result_manager(router);
// result_manager.AddObserver(observer);
// result_manager.StartSinksQuery(MediaCastMode::DEFAULT,
-// MediaSourceForPresentationUrl("http://google.com"));
+// MediaSourceForPresentationUrl("http://google.com"),
mark a. foltz 2016/03/03 22:58:37 Make the presentation URL different from the origi
matt.boetger 2016/03/04 00:22:11 Done.
+// GURL("http://google.com"));
// result_manager.StartSinksQuery(MediaCastMode::TAB_MIRROR,
-// MediaSourceForTab(123));
+// MediaSourceForTab(123), GURL(""));
mark a. foltz 2016/03/03 22:58:37 When would a sinks query not pass an origin?
matt.boetger 2016/03/04 00:22:11 For tabs.
// ...
// [Updates will be received by observer via OnResultsUpdated()]
// ...
@@ -83,7 +84,8 @@ class QueryResultManager {
// |cast_mode|, it is stopped.
//
// If |source| is empty, no new queries are begun.
- void StartSinksQuery(MediaCastMode cast_mode, const MediaSource& source);
+ void StartSinksQuery(MediaCastMode cast_mode,
+ const MediaSource& source);
// Stops notifying observers for |cast_mode|.
void StopSinksQuery(MediaCastMode cast_mode);

Powered by Google App Engine
This is Rietveld 408576698