Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Unified Diff: chrome/browser/media/router/media_router.mojom

Issue 1693963003: Pass origin to StartObservingMediaSinks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cache off media source Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router.mojom
diff --git a/chrome/browser/media/router/media_router.mojom b/chrome/browser/media/router/media_router.mojom
index 9a2f5e7e712f6fa1f0ef0764150f4f385d3a02b2..28a53bbfcf2870372c43765e0c7e86c4a939b4bb 100644
--- a/chrome/browser/media/router/media_router.mojom
+++ b/chrome/browser/media/router/media_router.mojom
@@ -215,10 +215,12 @@ interface MediaRouteProvider {
=> (bool sent);
// Starts querying for sinks capable of displaying |media_source|.
- StartObservingMediaSinks(string media_source);
+ // |origin| can be used to optionally verify that the origin is
mark a. foltz 2016/03/03 22:58:36 I would say: |origin| is the origin of the client
matt.boetger 2016/03/04 00:22:10 This is the second time you have suggested a chang
+ // authorized to issue the query.
+ StartObservingMediaSinks(string media_source, string origin);
// Stops querying sinks for |media_source|.
mark a. foltz 2016/03/03 22:58:36 And: |origin| is the origin of the client that sta
matt.boetger 2016/03/04 00:22:10 Done.
- StopObservingMediaSinks(string media_source);
+ StopObservingMediaSinks(string media_source, string origin);
// Starts reporting the state of active media routes via
// OnRoutesUpdated() in the context of the |media_source|. The
@@ -302,7 +304,7 @@ interface MediaRouter {
(string instance_id);
// Called when the Media Route Manager receives a new list of sinks.
- OnSinksReceived(string media_source, array<MediaSink> sinks);
+ OnSinksReceived(string media_source, string origin, array<MediaSink> sinks);
// Called when issues are reported for media routes.
OnIssue(Issue issue);

Powered by Google App Engine
This is Rietveld 408576698