Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1693963002: Fix parsing of generic local functions (issue 25769) (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : backout unintended changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-12 19:26:32 UTC) #2
Paul Berry
lgtm
4 years, 10 months ago (2016-02-12 19:29:54 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-12 19:38:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0616f707dd9d6b83c05f8e1360ebff56cb82ceac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698