Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1693953002: Minor WebGL 2 bug fixes for gl-object-get-calls test to pass (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
Reviewers:
bajones
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor WebGL 2 bug fixes for gl-object-get-calls test to pass BUG=295792 TEST=gl-object-get-calls.html webgl2 version R=bajones@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/afeae313797716e4729f75dc3455981582155285 Cr-Commit-Position: refs/heads/master@{#375251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
bajones
LGTM
4 years, 10 months ago (2016-02-12 19:12:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693953002/1
4 years, 10 months ago (2016-02-12 19:16:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-12 20:38:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693953002/1
4 years, 10 months ago (2016-02-12 20:47:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 20:53:02 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:45:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afeae313797716e4729f75dc3455981582155285
Cr-Commit-Position: refs/heads/master@{#375251}

Powered by Google App Engine
This is Rietveld 408576698