rework completion request resolve imports

rework completion request resolve imports
* rename resolveDirectives --> resolveImports
* rework resolveImports to return list of ImportElement rather than Directive
* new resolveDirectives test
* set priority source during completion tests

This and https://codereview.chromium.org/1685653002/ fixes https://github.com/dart-lang/sdk/issues/25690

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/6188d18eec1b063baf8d0af68c4eab4f47756812

[danrubel, 2016-02-12 18:41:14]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-12 18:58:34]

LGTM. Do we need to do something similar for completion in export directives?

[danrubel, 2016-02-12 18:59:56]

On 2016/02/12 18:58:34, Brian Wilkerson wrote:
> LGTM. Do we need to do something similar for completion in export directives?

Yes.

[danrubel, 2016-02-12 22:12:30]

Description was changed from

==========
rework completion request resolve imports
* rename resolveDirectives --> resolveImports
* rework resolveImports to return list of ImportElement rather than Directive
* new resolveDirectives test
* set priority source during completion tests

This and https://codereview.chromium.org/1685653002/ may fix
https://github.com/dart-lang/sdk/issues/25690
but I was not able to create what I felt was a good test for it.
==========

to

==========
rework completion request resolve imports
* rename resolveDirectives --> resolveImports
* rework resolveImports to return list of ImportElement rather than Directive
* new resolveDirectives test
* set priority source during completion tests

This and https://codereview.chromium.org/1685653002/ fixes
https://github.com/dart-lang/sdk/issues/25690
==========

[danrubel, 2016-02-12 22:13:22]

Found a way to simulate the problem in a test and updated this CL.
PTAL.

[Brian Wilkerson, 2016-02-12 22:35:23]

Nice! LGTM

[danrubel, 2016-02-14 04:15:22]

Description was changed from

==========
rework completion request resolve imports
* rename resolveDirectives --> resolveImports
* rework resolveImports to return list of ImportElement rather than Directive
* new resolveDirectives test
* set priority source during completion tests

This and https://codereview.chromium.org/1685653002/ fixes
https://github.com/dart-lang/sdk/issues/25690
==========

to

==========
rework completion request resolve imports
* rename resolveDirectives --> resolveImports
* rework resolveImports to return list of ImportElement rather than Directive
* new resolveDirectives test
* set priority source during completion tests

This and https://codereview.chromium.org/1685653002/ fixes
https://github.com/dart-lang/sdk/issues/25690

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6188d18eec1b063baf8d0af68c4eab4f47756812
==========

[danrubel, 2016-02-14 04:15:24]

Committed patchset #5 (id:80001) manually as
6188d18eec1b063baf8d0af68c4eab4f47756812 (presubmit successful).