Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 169393004: Fix heap snapshot crash when JSArrayBuffer has no backing_store. (Closed)

Created:
6 years, 10 months ago by alph
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix heap snapshot crash when JSArrayBuffer has no backing_store. LOG=N BUG=344239 R=dslomov@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
ptal
6 years, 10 months ago (2014-02-17 12:21:50 UTC) #1
yurys
lgtm
6 years, 10 months ago (2014-02-17 12:23:23 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years, 10 months ago (2014-02-17 12:35:35 UTC) #3
alph
6 years, 10 months ago (2014-02-17 12:39:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698