Make copySurface work in more situations.

Make copySurface work in more situations.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693923002

Committed: https://skia.googlesource.com/skia/+/083617b9a7247dd4c52f8dfd195fa34a083e6f1d

[bsalomon, 2016-02-12 18:26:15]

Description was changed from

==========
Make copySurface work in more situations.

BUG=skia:
==========

to

==========
Make copySurface work in more situations.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-12 18:36:13]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-02-12 18:36:13]

These changes allow the CopySurfaceTest to pass on systems where:

1) We chose to use EXT_multisample_render_to_texture even though ES 3 is
available

2) ES2, no glBlitFramebuffer

3) Limited glBlitFramebuffer (ANGLE).

[robertphillips, 2016-02-12 18:59:53]

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (right):

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLCaps.h#n...
src/gpu/gl/GrGLCaps.h:224: /**
Hmmm, this comment doesn't seem quite right. This method doesn't return
true/false.

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3272:
this->glCaps().glslCaps()->configOutputSwizzle(dst->config())) {
what's up with this ?

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3289: 
rm the !preferCopy here ?

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3695: this->unbindTextureFBOForCopy(GR_GL_FRAMEBUFFER,
src);
dstPoint.fY shouldn't be dstY ?

[bsalomon, 2016-02-12 19:09:15]

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (right):

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLCaps.h#n...
src/gpu/gl/GrGLCaps.h:224: /**
On 2016/02/12 18:59:53, robertphillips wrote:
> Hmmm, this comment doesn't seem quite right. This method doesn't return
> true/false.

Done.

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3272:
this->glCaps().glslCaps()->configOutputSwizzle(dst->config())) {
On 2016/02/12 18:59:53, robertphillips wrote:
> what's up with this ?

oops, put back return false.

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3289: 
On 2016/02/12 18:59:53, robertphillips wrote:
> rm the !preferCopy here ?

I realize it doesn't change the behavior but I think it serves to aid
readability (here is the non-preferred attempt to use copySurfaceAsDraw).

https://codereview.chromium.org/1693923002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3695: this->unbindTextureFBOForCopy(GR_GL_FRAMEBUFFER,
src);
On 2016/02/12 18:59:53, robertphillips wrote:
> dstPoint.fY shouldn't be dstY ?

No, didWriteToSurface takes rects in Skia's coords not GL coords.

[robertphillips, 2016-02-12 19:23:03]

lgtm

[bsalomon, 2016-02-12 19:32:40]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-02-12 19:32:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693923002/40001

[commit-bot: I haz the power, 2016-02-12 20:00:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 20:00:53]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[bsalomon, 2016-02-12 20:09:14]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-02-12 20:09:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693923002/40001

[commit-bot: I haz the power, 2016-02-12 20:10:16]

Description was changed from

==========
Make copySurface work in more situations.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make copySurface work in more situations.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/083617b9a7247dd4c52f8dfd195fa34a083e6f1d
==========

[commit-bot: I haz the power, 2016-02-12 20:10:17]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/083617b9a7247dd4c52f8dfd195fa34a083e6f1d