Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1693913003: Remove the FX_MIN macro. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the FX_MIN macro. Bin the min, bin the min, bin the min, bin the min, bin the min, bin the min, bin the min, bin the min, bin the min, bin the min, bin the min, bin the min, bin the min. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/45fe3c2eefd57b48d7307f9efe13d8019c96e489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M core/include/fxcrt/fx_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Lei, for review.
4 years, 10 months ago (2016-02-12 23:33:21 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-12 23:44:05 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-12 23:52:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45fe3c2eefd57b48d7307f9efe13d8019c96e489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698