Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1693883002: M49 compile fix for refs/branch-heads/2623@{#375} (Closed)

Created:
4 years, 10 months ago by boliu
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

M49 compile fix for refs/branch-heads/2623@{#375} That commit does not compile on M49 branch because M49 is missing this method rename in refs/heads/master@{#374337} Use the old method name instead. BUG=584986 TBR=tkent Committed: https://chromium.googlesource.com/chromium/src/+/b514ad82b39b3cfd5d40cc2ae269edf69a5034c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
boliu
PTAL TBR-ing a compile fix on branch
4 years, 10 months ago (2016-02-12 17:33:14 UTC) #4
boliu
Committed patchset #1 (id:1) manually as b514ad82b39b3cfd5d40cc2ae269edf69a5034c5 (tree was closed).
4 years, 10 months ago (2016-02-12 17:41:25 UTC) #6
tkent
4 years, 10 months ago (2016-02-14 23:19:37 UTC) #7
Message was sent while issue was closed.
lgtm.  Thank you!

Powered by Google App Engine
This is Rietveld 408576698