Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1693863002: Revert of Revise the code for premultiplyAlpha=false for createImageBitmap(HTMLCanvasElement) (Closed)

Created:
4 years, 10 months ago by xidachen
Modified:
4 years, 10 months ago
Reviewers:
jbroman, Justin Novosad
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revise the code for premultiplyAlpha=false for createImageBitmap(HTMLCanvasElement) (patchset #1 id:1 of https://codereview.chromium.org/1694793002/ ) Reason for revert: Cause compilation error https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/37356/steps/compile/logs/stdio Original issue's description: > Revise the code for premultiplyAlpha=false for createImageBitmap(HTMLCanvasElement) > > It turns out that HTMLCanvasElement is always premultiplied in Blink, so > we cannot simply use a decoder to re-decode it to a un-premultiplied format. > The strategy this CL takes is that after cropping the HTMLCanvasElement > into a SkImage, we convert the SkImage into a un-premultiplied format if > that's what the option specifies. TBR=junov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a4b265467f94e3e5d173868f2781d43ddc2c69aa Cr-Commit-Position: refs/heads/master@{#375193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+884 lines, -90 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage-with-options.html View 6 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage-with-options-expected.txt View 60 chunks +880 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
xidachen
Created Revert of Revise the code for premultiplyAlpha=false for createImageBitmap(HTMLCanvasElement)
4 years, 10 months ago (2016-02-12 16:33:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693863002/1
4 years, 10 months ago (2016-02-12 16:33:48 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-02-12 16:33:50 UTC) #4
jbroman
lgtm
4 years, 10 months ago (2016-02-12 16:34:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693863002/1
4 years, 10 months ago (2016-02-12 16:34:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 16:35:18 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:43:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4b265467f94e3e5d173868f2781d43ddc2c69aa
Cr-Commit-Position: refs/heads/master@{#375193}

Powered by Google App Engine
This is Rietveld 408576698