VM: Correctly intrinsify implicit getters/setters when using field guards

VM: Correctly intrinsify implicit getters/setters when using field guards

The unoptimized code cannot depend on guarded cid when using code collection
since it may be lazily regenerated and has to match the original version.

BUG=dartbug.com/25771
R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a6e4f35e0bcfb0206e63b834cb03b9a0c31996d7

[Florian Schneider, 2016-02-12 14:16:19]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-02-12 14:20:42]

lgtm

https://codereview.chromium.org/1693843002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1693843002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:1088: if (FLAG_precompilation &&
FLAG_precompilation -> !FLAG_use_field_guards?

https://codereview.chromium.org/1693843002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:1104: return true;
alternatively you can do

return !FLAG_use_field_guards 

instead 

return true

then we would append the body and we will have the deoptimization target

[Florian Schneider, 2016-02-12 14:25:15]

Description was changed from

==========
VM: Don't intrinsify implicit getters/setters when using field guards

The unoptimized code cannot depend on guarded cid when using code collection
since it may be lazily regenerated and has to match the original version.

BUG=dartbug.com/25771
==========

to

==========
VM: Correctly intrinsify implicit getters/setters when using field guards

The unoptimized code cannot depend on guarded cid when using code collection
since it may be lazily regenerated and has to match the original version.

BUG=dartbug.com/25771
==========

[Florian Schneider, 2016-02-12 14:25:21]

https://codereview.chromium.org/1693843002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1693843002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:1104: return true;
On 2016/02/12 14:20:42, Vyacheslav Egorov (Google) wrote:
> alternatively you can do
> 
> return !FLAG_use_field_guards 
> 
> instead 
> 
> return true
> 
> then we would append the body and we will have the deoptimization target

Done.

[Florian Schneider, 2016-02-12 14:26:28]

Description was changed from

==========
VM: Correctly intrinsify implicit getters/setters when using field guards

The unoptimized code cannot depend on guarded cid when using code collection
since it may be lazily regenerated and has to match the original version.

BUG=dartbug.com/25771
==========

to

==========
VM: Correctly intrinsify implicit getters/setters when using field guards

The unoptimized code cannot depend on guarded cid when using code collection
since it may be lazily regenerated and has to match the original version.

BUG=dartbug.com/25771
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a6e4f35e0bcfb0206e63b834cb03b9a0c31996d7
==========

[Florian Schneider, 2016-02-12 14:26:30]

Committed patchset #3 (id:40001) manually as
a6e4f35e0bcfb0206e63b834cb03b9a0c31996d7 (presubmit successful).

[srdjan, 2016-02-12 17:03:49]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-02-12 17:03:50]

DBC

https://codereview.chromium.org/1693843002/diff/40001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1693843002/diff/40001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:1099: return !FLAG_use_field_guards;
It would have been helpful to add comment why it depends on field guards