Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: src/runtime/runtime-operators.cc

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-operators.cc
diff --git a/src/runtime/runtime-operators.cc b/src/runtime/runtime-operators.cc
index b5e92af8f6e0277252b6b0473889796456613e1a..02fd0cd33281b62be650733085a10bf7085e9d3e 100644
--- a/src/runtime/runtime-operators.cc
+++ b/src/runtime/runtime-operators.cc
@@ -21,18 +21,6 @@ RUNTIME_FUNCTION(Runtime_Multiply) {
}
-RUNTIME_FUNCTION(Runtime_Multiply_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::Multiply(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_Divide) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -45,18 +33,6 @@ RUNTIME_FUNCTION(Runtime_Divide) {
}
-RUNTIME_FUNCTION(Runtime_Divide_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::Divide(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_Modulus) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -69,18 +45,6 @@ RUNTIME_FUNCTION(Runtime_Modulus) {
}
-RUNTIME_FUNCTION(Runtime_Modulus_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::Modulus(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_Add) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -93,18 +57,6 @@ RUNTIME_FUNCTION(Runtime_Add) {
}
-RUNTIME_FUNCTION(Runtime_Add_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::Add(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_Subtract) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -117,18 +69,6 @@ RUNTIME_FUNCTION(Runtime_Subtract) {
}
-RUNTIME_FUNCTION(Runtime_Subtract_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::Subtract(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_ShiftLeft) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -141,18 +81,6 @@ RUNTIME_FUNCTION(Runtime_ShiftLeft) {
}
-RUNTIME_FUNCTION(Runtime_ShiftLeft_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::ShiftLeft(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_ShiftRight) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -165,18 +93,6 @@ RUNTIME_FUNCTION(Runtime_ShiftRight) {
}
-RUNTIME_FUNCTION(Runtime_ShiftRight_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::ShiftRight(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_ShiftRightLogical) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -189,19 +105,6 @@ RUNTIME_FUNCTION(Runtime_ShiftRightLogical) {
}
-RUNTIME_FUNCTION(Runtime_ShiftRightLogical_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result,
- Object::ShiftRightLogical(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_BitwiseAnd) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -214,18 +117,6 @@ RUNTIME_FUNCTION(Runtime_BitwiseAnd) {
}
-RUNTIME_FUNCTION(Runtime_BitwiseAnd_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::BitwiseAnd(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_BitwiseOr) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -238,18 +129,6 @@ RUNTIME_FUNCTION(Runtime_BitwiseOr) {
}
-RUNTIME_FUNCTION(Runtime_BitwiseOr_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::BitwiseOr(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
-
RUNTIME_FUNCTION(Runtime_BitwiseXor) {
HandleScope scope(isolate);
DCHECK_EQ(2, args.length());
@@ -261,17 +140,5 @@ RUNTIME_FUNCTION(Runtime_BitwiseXor) {
return *result;
}
-
-RUNTIME_FUNCTION(Runtime_BitwiseXor_Strong) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- CONVERT_ARG_HANDLE_CHECKED(Object, lhs, 0);
- CONVERT_ARG_HANDLE_CHECKED(Object, rhs, 1);
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result, Object::BitwiseXor(isolate, lhs, rhs, Strength::STRONG));
- return *result;
-}
-
} // namespace internal
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698