Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/objects.h

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/crankshaft/hydrogen-instructions.h ('K') | « src/mips64/code-stubs-mips64.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 2c6e91b11057e1d06a29f7a1b2e871395b9750e9..f93c60ccd49926ddf282b39b5e3ae028aa32d85f 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1113,8 +1113,8 @@ class Object {
bool BooleanValue(); // ECMA-262 9.2.
// ES6 section 7.2.11 Abstract Relational Comparison
- MUST_USE_RESULT static Maybe<ComparisonResult> Compare(
- Handle<Object> x, Handle<Object> y, Strength strength = Strength::WEAK);
+ MUST_USE_RESULT static Maybe<ComparisonResult> Compare(Handle<Object> x,
+ Handle<Object> y);
// ES6 section 7.2.12 Abstract Equality Comparison
MUST_USE_RESULT static Maybe<bool> Equals(Handle<Object> x, Handle<Object> y);
@@ -1175,55 +1175,54 @@ class Object {
static Handle<String> TypeOf(Isolate* isolate, Handle<Object> object);
// ES6 section 12.6 Multiplicative Operators
- MUST_USE_RESULT static MaybeHandle<Object> Multiply(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
- MUST_USE_RESULT static MaybeHandle<Object> Divide(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
- MUST_USE_RESULT static MaybeHandle<Object> Modulus(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
+ MUST_USE_RESULT static MaybeHandle<Object> Multiply(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
+ MUST_USE_RESULT static MaybeHandle<Object> Divide(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
+ MUST_USE_RESULT static MaybeHandle<Object> Modulus(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
// ES6 section 12.7 Additive Operators
- MUST_USE_RESULT static MaybeHandle<Object> Add(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
- MUST_USE_RESULT static MaybeHandle<Object> Subtract(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
+ MUST_USE_RESULT static MaybeHandle<Object> Add(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
+ MUST_USE_RESULT static MaybeHandle<Object> Subtract(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
// ES6 section 12.8 Bitwise Shift Operators
- MUST_USE_RESULT static MaybeHandle<Object> ShiftLeft(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
- MUST_USE_RESULT static MaybeHandle<Object> ShiftRight(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
+ MUST_USE_RESULT static MaybeHandle<Object> ShiftLeft(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
+ MUST_USE_RESULT static MaybeHandle<Object> ShiftRight(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
MUST_USE_RESULT static MaybeHandle<Object> ShiftRightLogical(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
+ Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs);
// ES6 section 12.9 Relational Operators
- MUST_USE_RESULT static inline Maybe<bool> GreaterThan(
- Handle<Object> x, Handle<Object> y, Strength strength = Strength::WEAK);
+ MUST_USE_RESULT static inline Maybe<bool> GreaterThan(Handle<Object> x,
+ Handle<Object> y);
MUST_USE_RESULT static inline Maybe<bool> GreaterThanOrEqual(
- Handle<Object> x, Handle<Object> y, Strength strength = Strength::WEAK);
- MUST_USE_RESULT static inline Maybe<bool> LessThan(
- Handle<Object> x, Handle<Object> y, Strength strength = Strength::WEAK);
- MUST_USE_RESULT static inline Maybe<bool> LessThanOrEqual(
- Handle<Object> x, Handle<Object> y, Strength strength = Strength::WEAK);
+ Handle<Object> x, Handle<Object> y);
+ MUST_USE_RESULT static inline Maybe<bool> LessThan(Handle<Object> x,
+ Handle<Object> y);
+ MUST_USE_RESULT static inline Maybe<bool> LessThanOrEqual(Handle<Object> x,
+ Handle<Object> y);
// ES6 section 12.11 Binary Bitwise Operators
- MUST_USE_RESULT static MaybeHandle<Object> BitwiseAnd(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
- MUST_USE_RESULT static MaybeHandle<Object> BitwiseOr(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
- MUST_USE_RESULT static MaybeHandle<Object> BitwiseXor(
- Isolate* isolate, Handle<Object> lhs, Handle<Object> rhs,
- Strength strength = Strength::WEAK);
+ MUST_USE_RESULT static MaybeHandle<Object> BitwiseAnd(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
+ MUST_USE_RESULT static MaybeHandle<Object> BitwiseOr(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
+ MUST_USE_RESULT static MaybeHandle<Object> BitwiseXor(Isolate* isolate,
+ Handle<Object> lhs,
+ Handle<Object> rhs);
MUST_USE_RESULT static MaybeHandle<Object> GetProperty(
LookupIterator* it, LanguageMode language_mode = SLOPPY);
« src/crankshaft/hydrogen-instructions.h ('K') | « src/mips64/code-stubs-mips64.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698