Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: src/objects-inl.h

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index a8c5baf5104d1f739997209c84a7387fdd42132f..1cb389b323a84196b5b88540e41941131e764366 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -7014,9 +7014,8 @@ String* String::GetForwardedInternalizedString() {
// static
-Maybe<bool> Object::GreaterThan(Handle<Object> x, Handle<Object> y,
- Strength strength) {
- Maybe<ComparisonResult> result = Compare(x, y, strength);
+Maybe<bool> Object::GreaterThan(Handle<Object> x, Handle<Object> y) {
+ Maybe<ComparisonResult> result = Compare(x, y);
if (result.IsJust()) {
switch (result.FromJust()) {
case ComparisonResult::kGreaterThan:
@@ -7032,9 +7031,8 @@ Maybe<bool> Object::GreaterThan(Handle<Object> x, Handle<Object> y,
// static
-Maybe<bool> Object::GreaterThanOrEqual(Handle<Object> x, Handle<Object> y,
- Strength strength) {
- Maybe<ComparisonResult> result = Compare(x, y, strength);
+Maybe<bool> Object::GreaterThanOrEqual(Handle<Object> x, Handle<Object> y) {
+ Maybe<ComparisonResult> result = Compare(x, y);
if (result.IsJust()) {
switch (result.FromJust()) {
case ComparisonResult::kEqual:
@@ -7050,9 +7048,8 @@ Maybe<bool> Object::GreaterThanOrEqual(Handle<Object> x, Handle<Object> y,
// static
-Maybe<bool> Object::LessThan(Handle<Object> x, Handle<Object> y,
- Strength strength) {
- Maybe<ComparisonResult> result = Compare(x, y, strength);
+Maybe<bool> Object::LessThan(Handle<Object> x, Handle<Object> y) {
+ Maybe<ComparisonResult> result = Compare(x, y);
if (result.IsJust()) {
switch (result.FromJust()) {
case ComparisonResult::kLessThan:
@@ -7068,9 +7065,8 @@ Maybe<bool> Object::LessThan(Handle<Object> x, Handle<Object> y,
// static
-Maybe<bool> Object::LessThanOrEqual(Handle<Object> x, Handle<Object> y,
- Strength strength) {
- Maybe<ComparisonResult> result = Compare(x, y, strength);
+Maybe<bool> Object::LessThanOrEqual(Handle<Object> x, Handle<Object> y) {
+ Maybe<ComparisonResult> result = Compare(x, y);
if (result.IsJust()) {
switch (result.FromJust()) {
case ComparisonResult::kEqual:

Powered by Google App Engine
This is Rietveld 408576698