src/crankshaft/arm64/lithium-arm64.h - Issue 1693833002: Remove strong mode support from binary operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm64/lithium-arm64.h

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/arm64/lithium-arm64.h

diff --git a/src/crankshaft/arm64/lithium-arm64.h b/src/crankshaft/arm64/lithium-arm64.h

index 7ee3402538e46fd873dba68aed286fce2cc74f71..5a1bc701c712372124b9c87f26ee0de845caf875 100644

--- a/src/crankshaft/arm64/lithium-arm64.h

+++ b/src/crankshaft/arm64/lithium-arm64.h

@@ -716,8 +716,6 @@ class LArithmeticT final : public LTemplateInstruction<1, 3, 0> {

DECLARE_HYDROGEN_ACCESSOR(BinaryOperation)

- Strength strength() { return hydrogen()->strength(); }

private:

Token::Value op_;

};

@@ -1139,8 +1137,6 @@ class LCmpT final : public LTemplateInstruction<1, 3, 0> {

DECLARE_CONCRETE_INSTRUCTION(CmpT, "cmp-t")

DECLARE_HYDROGEN_ACCESSOR(CompareGeneric)

- Strength strength() { return hydrogen()->strength(); }

Token::Value op() const { return hydrogen()->token(); }

};