Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index 43a7e44af6a0183d51f975c8bbfce9aec5914b4c..f374f1c18e7fd05dec98e88d852bc6f1b7ebde8e 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -1468,15 +1468,15 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
if_leftisstring.If<HIsStringAndBranch>(left);
if_leftisstring.Then();
{
- Push(BuildBinaryOperation(
- state.op(), left, right, Type::String(), right_type, result_type,
- state.fixed_right_arg(), allocation_mode, state.strength()));
+ Push(BuildBinaryOperation(state.op(), left, right, Type::String(),
+ right_type, result_type,
+ state.fixed_right_arg(), allocation_mode));
}
if_leftisstring.Else();
{
- Push(BuildBinaryOperation(
- state.op(), left, right, left_type, right_type, result_type,
- state.fixed_right_arg(), allocation_mode, state.strength()));
+ Push(BuildBinaryOperation(state.op(), left, right, left_type,
+ right_type, result_type,
+ state.fixed_right_arg(), allocation_mode));
}
if_leftisstring.End();
result = Pop();
@@ -1485,23 +1485,23 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
if_rightisstring.If<HIsStringAndBranch>(right);
if_rightisstring.Then();
{
- Push(BuildBinaryOperation(
- state.op(), left, right, left_type, Type::String(), result_type,
- state.fixed_right_arg(), allocation_mode, state.strength()));
+ Push(BuildBinaryOperation(state.op(), left, right, left_type,
+ Type::String(), result_type,
+ state.fixed_right_arg(), allocation_mode));
}
if_rightisstring.Else();
{
- Push(BuildBinaryOperation(
- state.op(), left, right, left_type, right_type, result_type,
- state.fixed_right_arg(), allocation_mode, state.strength()));
+ Push(BuildBinaryOperation(state.op(), left, right, left_type,
+ right_type, result_type,
+ state.fixed_right_arg(), allocation_mode));
}
if_rightisstring.End();
result = Pop();
}
} else {
- result = BuildBinaryOperation(
- state.op(), left, right, left_type, right_type, result_type,
- state.fixed_right_arg(), allocation_mode, state.strength());
+ result = BuildBinaryOperation(state.op(), left, right, left_type,
+ right_type, result_type,
+ state.fixed_right_arg(), allocation_mode);
}
// If we encounter a generic argument, the number conversion is
@@ -1535,7 +1535,7 @@ HValue* CodeStubGraphBuilder<BinaryOpWithAllocationSiteStub>::BuildCodeStub() {
return BuildBinaryOperation(state.op(), left, right, left_type, right_type,
result_type, state.fixed_right_arg(),
- allocation_mode, state.strength());
+ allocation_mode);
}

Powered by Google App Engine
This is Rietveld 408576698