Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: src/crankshaft/ia32/lithium-ia32.h

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 5 #ifndef V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
6 #define V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 6 #define V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
7 7
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/crankshaft/lithium-allocator.h" 10 #include "src/crankshaft/lithium-allocator.h"
(...skipping 1104 matching lines...) Expand 10 before | Expand all | Expand 10 after
1115 public: 1115 public:
1116 LCmpT(LOperand* context, LOperand* left, LOperand* right) { 1116 LCmpT(LOperand* context, LOperand* left, LOperand* right) {
1117 inputs_[0] = context; 1117 inputs_[0] = context;
1118 inputs_[1] = left; 1118 inputs_[1] = left;
1119 inputs_[2] = right; 1119 inputs_[2] = right;
1120 } 1120 }
1121 1121
1122 DECLARE_CONCRETE_INSTRUCTION(CmpT, "cmp-t") 1122 DECLARE_CONCRETE_INSTRUCTION(CmpT, "cmp-t")
1123 DECLARE_HYDROGEN_ACCESSOR(CompareGeneric) 1123 DECLARE_HYDROGEN_ACCESSOR(CompareGeneric)
1124 1124
1125 Strength strength() { return hydrogen()->strength(); }
1126
1127 LOperand* context() { return inputs_[0]; } 1125 LOperand* context() { return inputs_[0]; }
1128 Token::Value op() const { return hydrogen()->token(); } 1126 Token::Value op() const { return hydrogen()->token(); }
1129 }; 1127 };
1130 1128
1131 1129
1132 class LInstanceOf final : public LTemplateInstruction<1, 3, 0> { 1130 class LInstanceOf final : public LTemplateInstruction<1, 3, 0> {
1133 public: 1131 public:
1134 LInstanceOf(LOperand* context, LOperand* left, LOperand* right) { 1132 LInstanceOf(LOperand* context, LOperand* left, LOperand* right) {
1135 inputs_[0] = context; 1133 inputs_[0] = context;
1136 inputs_[1] = left; 1134 inputs_[1] = left;
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 LOperand* left() { return inputs_[1]; } 1442 LOperand* left() { return inputs_[1]; }
1445 LOperand* right() { return inputs_[2]; } 1443 LOperand* right() { return inputs_[2]; }
1446 Token::Value op() const { return op_; } 1444 Token::Value op() const { return op_; }
1447 1445
1448 Opcode opcode() const override { return LInstruction::kArithmeticT; } 1446 Opcode opcode() const override { return LInstruction::kArithmeticT; }
1449 void CompileToNative(LCodeGen* generator) override; 1447 void CompileToNative(LCodeGen* generator) override;
1450 const char* Mnemonic() const override; 1448 const char* Mnemonic() const override;
1451 1449
1452 DECLARE_HYDROGEN_ACCESSOR(BinaryOperation) 1450 DECLARE_HYDROGEN_ACCESSOR(BinaryOperation)
1453 1451
1454 Strength strength() { return hydrogen()->strength(); }
1455
1456 private: 1452 private:
1457 Token::Value op_; 1453 Token::Value op_;
1458 }; 1454 };
1459 1455
1460 1456
1461 class LReturn final : public LTemplateInstruction<0, 3, 0> { 1457 class LReturn final : public LTemplateInstruction<0, 3, 0> {
1462 public: 1458 public:
1463 explicit LReturn(LOperand* value, 1459 explicit LReturn(LOperand* value,
1464 LOperand* context, 1460 LOperand* context,
1465 LOperand* parameter_count) { 1461 LOperand* parameter_count) {
(...skipping 1281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2747 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2743 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2748 }; 2744 };
2749 2745
2750 #undef DECLARE_HYDROGEN_ACCESSOR 2746 #undef DECLARE_HYDROGEN_ACCESSOR
2751 #undef DECLARE_CONCRETE_INSTRUCTION 2747 #undef DECLARE_CONCRETE_INSTRUCTION
2752 2748
2753 } // namespace internal 2749 } // namespace internal
2754 } // namespace v8 2750 } // namespace v8
2755 2751
2756 #endif // V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 2752 #endif // V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698