Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: tests/standalone/io/raw_socket_test.dart

Issue 169383003: Make event-handlers edge-triggered and move socket-state to Dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_server_test.dart ('k') | tests/standalone/io/secure_builtin_roots_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/raw_socket_test.dart
diff --git a/tests/standalone/io/raw_socket_test.dart b/tests/standalone/io/raw_socket_test.dart
index ddf5611194e8512d42cc2ee025de68ca4e247b92..bc537f516ce2740db2331b99df3065349aaca1f3 100644
--- a/tests/standalone/io/raw_socket_test.dart
+++ b/tests/standalone/io/raw_socket_test.dart
@@ -64,9 +64,10 @@ void testInvalidBind() {
void testSimpleConnect() {
asyncStart();
RawServerSocket.bind(InternetAddress.LOOPBACK_IP_V4, 0).then((server) {
- server.listen((_) { });
- RawSocket.connect("127.0.0.1", server.port).then((_) {
+ server.listen((socket) { socket.close(); });
+ RawSocket.connect("127.0.0.1", server.port).then((socket) {
server.close();
+ socket.close();
asyncEnd();
});
});
@@ -113,9 +114,11 @@ void testServerListenAfterConnect() {
asyncStart();
RawServerSocket.bind(InternetAddress.LOOPBACK_IP_V4, 0).then((server) {
Expect.isTrue(server.port > 0);
- RawSocket.connect("127.0.0.1", server.port).then((_) {
- server.listen((_) {
+ RawSocket.connect("127.0.0.1", server.port).then((client) {
+ server.listen((socket) {
+ client.close();
server.close();
+ socket.close();
asyncEnd();
});
});
@@ -258,7 +261,8 @@ testPauseServerSocket() {
asyncStart();
RawServerSocket.bind(InternetAddress.LOOPBACK_IP_V4, 0).then((server) {
Expect.isTrue(server.port > 0);
- var subscription = server.listen((_) {
+ var subscription = server.listen((socket) {
+ socket.close();
Expect.isTrue(resumed);
if (++acceptCount == socketCount) {
server.close();
@@ -272,14 +276,17 @@ testPauseServerSocket() {
subscription.pause();
var connectCount = 0;
for (int i = 0; i < socketCount / 2; i++) {
- RawSocket.connect("127.0.0.1", server.port).then((_) {
+ RawSocket.connect("127.0.0.1", server.port).then((socket) {
if (++connectCount == socketCount / 2) {
subscription.resume();
resumed = true;
for (int i = connectCount; i < socketCount; i++) {
- RawSocket.connect("127.0.0.1", server.port).then((_) {});
+ RawSocket.connect("127.0.0.1", server.port).then((socket) {
+ socket.close();
+ });
}
}
+ socket.close();
});
}
});
« no previous file with comments | « tests/standalone/io/http_server_test.dart ('k') | tests/standalone/io/secure_builtin_roots_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698